-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAT-688] Migrate ListWorkflows call from V1 to V2 #118
Conversation
Total Coverage: 32.18% Coverage Report
|
3ba3ff9
to
da60c21
Compare
Total Coverage: 32.18% Coverage Report
|
Total Coverage: 32.35% Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Question from my end, was any of this "generated" code? Or did you also write the client bits? Also awesome job!
None of this was generated, just had to look in the generated code to get the return types for some of the functions |
Total Coverage: 32.16% Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks for making those updates :). lgtm!!
Migrate ListWorkflows call to use Strawberry Shake, and add an integration test for the call.