add argument exception for invalid batch size

IndicoDataSolutions · Mar 11, 2024 · d281349 · d281349
1 parent 99ec729
commit d281349
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/IndicoV2.Abstractions/Submissions/ISubmissionsClient.cs b/IndicoV2.Abstractions/Submissions/ISubmissionsClient.cs
@@ -34,7 +34,7 @@ public interface ISubmissionsClient
         /// <param name="resultsFileVersion">Optional. Specifies version to use for the results file.</param>
         /// <param name="bundle">Optional. Flag to batch all files under a single submission id.</param>
         /// <returns><c><see cref="IEnumerable{T}">IEnumerable</see></c> of submissions ids.</returns>
-        Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<(string Name, Stream Content)> files, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false);
+        Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<(string Name, Stream Content)> files, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false, int batchSize = 20);
 
         /// <summary>
         /// Method creates <c><see cref="ISubmission"/></c>.
@@ -56,7 +56,7 @@ public interface ISubmissionsClient
         /// <param name="resultsFileVersion">Optional. Specifies version to use for the results file.</param>
         /// <param name="bundle">Optional. Flag to batch all files under a single submission id.</param>
         /// <returns><c><see cref="IEnumerable{T}"/></c> of submissions ids.</returns>
-        Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<string> paths, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false);
+        Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<string> paths, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false, int batchSize = 20);
 
         /// <summary>
         /// Method lists <c><see cref="ISubmission"/></c>.

diff --git a/IndicoV2/Storage/StorageClient.cs b/IndicoV2/Storage/StorageClient.cs
@@ -69,6 +69,10 @@ public JArray Serialize(IEnumerable<IFileMetadata> filesMetadata)
         public async Task<(string Name, string Meta)[]> UploadAsync(IEnumerable<(string Path, Stream Content)> files,
             CancellationToken cancellationToken, int batchSize = 20)
         {
+            if (batchSize <= 0)
+            {
+                throw new ArgumentException("Batch size must be greater than 0.");
+            }
             var results = new (string Name, string Meta)[] { };
             var batches = files.Chunk(batchSize);
             foreach (var batch in batches)

diff --git a/IndicoV2/Submissions/SubmissionsClient.cs b/IndicoV2/Submissions/SubmissionsClient.cs
@@ -51,9 +51,9 @@ public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<Stre
             return await _strawberryShakeClient.Submissions().Create(workflowId, (IEnumerable<(string Name, string Meta)>)files, cancellationToken, (SubmissionResultVersion?) resultsFileVersion, bundle);
         }
 
-        public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<(string Name, Stream Content)> filesToUpload, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false)
+        public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<(string Name, Stream Content)> filesToUpload, CancellationToken cancellationToken = default, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false, int batchSize = 20)
         {
-            var filesUploaded = await _indicoClient.Storage().UploadAsync(filesToUpload, cancellationToken);
+            var filesUploaded = await _indicoClient.Storage().UploadAsync(filesToUpload, cancellationToken, batchSize: batchSize);
             return await _strawberryShakeClient.Submissions().Create(workflowId, filesUploaded, cancellationToken, (SubmissionResultVersion?)resultsFileVersion, bundle);
         }
 
@@ -68,7 +68,7 @@ public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<Uri>
             await _strawberryShakeClient.Submissions().CreateUri(workflowId, uris, cancellationToken);
 
         public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<string> paths,
-          CancellationToken cancellationToken, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false)
+          CancellationToken cancellationToken, SubmissionResultsFileVersion? resultsFileVersion = null, bool bundle = false, int batchSize = 20)
         {
             var filesToUpload = new List<(string Name, Stream content)>();
             foreach (var path in paths)
@@ -84,7 +84,7 @@ public async Task<IEnumerable<int>> CreateAsync(int workflowId, IEnumerable<stri
                 }
 
             }
-            return await CreateAsync(workflowId, filesToUpload: filesToUpload, cancellationToken, resultsFileVersion, bundle);
+            return await CreateAsync(workflowId, filesToUpload: filesToUpload, cancellationToken, resultsFileVersion, bundle, batchSize);
         }
 
         [Obsolete("This is the Legacy version and will be deprecated. Please use ListAsync instead.")]