Fixes #49 - report map doesn't respect template #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains a relatively small amount of code to implement the enhancement. However, includes many style changes and comments to improve legibility. Most significant alteration is to use of the $colsToInclude array which was previously empty unless specifically used to constrain columns sent to JavaScript. Now it is always employed to list output columns. This is because the code also includes a change to prevent output of columns that are marked as not visible (unless required for mapping, e.g. geom)
johnvanbreda
approved these changes
Aug 2, 2017
|
Thanks John, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting as a pull request since this includes a bit of restructuring
which might benefit from a second pair of eyes.
Contains a relatively small amount of code to implement the enhancement.
However, includes many style changes and comments to improve legibility.
Most significant alteration is to use of the $colsToInclude array which
was previously empty unless specifically used to constrain columns sent
to JavaScript. Now it is always employed to list output columns. This is
because the code also includes a change to prevent output of columns
that are marked as not visible (unless required for mapping, e.g. geom)