Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-14 Fix layout flaws in the German version #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christophdubach
Copy link

@christophdubach christophdubach commented Mar 30, 2024

Fixes #14

  • Limited the <h1> width to prevent text and image overlapping
  • Updated the in-page nav CSS selector to add the styling to the German variant
  • Added missing umlauts to the Google font params
  • Allowed long words to be broken with a soft hyphen

@@ -249,13 +257,15 @@ main ul li + li {
padding-top: 0.75rem;
}

nav[aria-label="page"] {
nav[aria-label="page"],
nav[aria-label="Seite"] {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See issue #18

@LJWatson
Copy link
Contributor

LJWatson commented Apr 3, 2024

Thank you @christophdubach.

@IanPouncey or @Heydon could you review this PR when you get a moment possibly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

German Translation Website Layout Errors
2 participants