Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Commit

Permalink
Correct option docs from MANTA-1487
Browse files Browse the repository at this point in the history
  • Loading branch information
ctsa committed Jul 17, 2019
1 parent 27ba65e commit 75b5c38
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 21 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## v1.6.0 - 2019-06-25
This is a significant engineering update from the v1.5.x release, in which the SV candidate generation step has been changed to a single multi-threaded process to improve task scheduling. This slightly improves average runtime and reduces runtime variability. With this update, support for job distribution over SGE is dropped.
This is a significant engineering update from the v1.5.1 release, in which the SV candidate generation step has been changed to a single multi-threaded process to improve task scheduling. This slightly improves average runtime and reduces runtime variability. With this update, support for job distribution over SGE is dropped.

### Added
- Add configuration option to turn off the evidence signal filter during candidate generation (DRAGEN-1873)
Expand All @@ -16,13 +16,13 @@ This is a significant engineering update from the v1.5.x release, in which the S
This is a minor update from v1.5.0.

### Changed
- Make existingAlignmentStats as a fallback option (MANTA-1487)
- It prioritizes stats estimated from the alignment file and allows static stats file when stats estimation fails due to insufficient high-confidence read pairs.
- Change behavior of existingAlignmentStats option (MANTA-1487)
- Alignment statistics provided by this option will only be used as a default when direct estimation from the sample fails.
- Minor updates on Methods writeup (MANTA-1522)

### Fixed
- Fix a bug in selecting large insertion candidates (MANTA-1496)
- Fix a minor bug in QC small SV alignment (MANTA-1498)
- Fix a minor bug in QC small alignment SV (MANTA-1498)

## v1.5.0 - 2018-11-12
This is a major update from v1.4.0, featuring improved precision and stability, a new configurable option of overlapping pair reads, and a few bug fixes. VCF representation is improved by introducing a couple of new filters and representing inversions as two breakend records.
Expand Down
3 changes: 0 additions & 3 deletions docs/userGuide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -662,9 +662,6 @@ These options are useful for Manta development and debugging:
* The `--generateEvidenceBam` option can be used to generate bam files
of evidence reads for SVs listed in the candidate vcf file.
(More details in the section "Generating evidence bams" below)
* The `--default-stats-file` option can be used to provide a file
containing read group statistics for Manta to fall back on when stats
estimation fails due to insufficient high-confidence read pairs.


### Extended use cases
Expand Down
12 changes: 6 additions & 6 deletions src/python/bin/configManta.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ def addWorkflowGroupOptions(self,group) :


def addExtendedGroupOptions(self,group) :
group.add_option("--existingAlignStatsFile",
dest="existingAlignStatsFile", metavar="FILE",
help="Pre-calculated alignment statistics file. Skips alignment stats calculation.")
group.add_option("--defaultAlignStatsFile", "--existingAlignStatsFile",
dest="defaultAlignStatsFile", metavar="FILE",
help="Default alignment statistics to use when direct estimation from the sample fails")
group.add_option("--useExistingChromDepths",
dest="useExistingChromDepths", action="store_true",
help="Use pre-calculated chromosome depths.")
Expand All @@ -102,7 +102,7 @@ def getOptionDefaults(self) :
'isRNA' : False,
'isOutputContig' : False,
'isUnstrandedRNA' : False,
'existingAlignStatsFile' : None,
'defaultAlignStatsFile' : None,
'useExistingChromDepths' : False,
'isRetainTempFiles' : False,
'isGenerateSupportBam' : False
Expand Down Expand Up @@ -136,8 +136,8 @@ def safeLen(x) :
if options.isUnstrandedRNA :
raise OptParseException("Unstranded only applied for RNA inputs")

if options.existingAlignStatsFile is not None :
options.existingAlignStatsFile=validateFixExistingFileArg(options.existingAlignStatsFile,"existing align stats")
if options.defaultAlignStatsFile is not None :
options.defaultAlignStatsFile=validateFixExistingFileArg(options.defaultAlignStatsFile,"default align stats")

groomBamList(options.normalBamList,"normal sample")
groomBamList(options.tumorBamList, "tumor sample")
Expand Down
10 changes: 2 additions & 8 deletions src/python/lib/mantaWorkflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,6 @@ def summarizeStats(self, taskPrefix="", dependencies=None) :

return summaryTasks

def copyStats(self) :
statsPath=self.paths.getStatsPath()
existingStatsPath=self.params.existingAlignStatsFile

shutil.copy(existingStatsPath, statsPath)

def runStats(self,taskPrefix="",dependencies=None) :

statsPath=self.paths.getStatsPath()
Expand All @@ -201,8 +195,8 @@ def runStats(self,taskPrefix="",dependencies=None) :
cmd.extend(["--ref", self.params.referenceFasta])
cmd.extend(["--output-file",tmpStatsFiles[-1]])
cmd.extend(["--align-file",bamPath])
if self.params.existingAlignStatsFile:
cmd.extend(["--default-stats-file",self.params.existingAlignStatsFile])
if self.params.defaultAlignStatsFile:
cmd.extend(["--default-stats-file",self.params.defaultAlignStatsFile])

statsTasks.add(self.addTask(preJoin(taskPrefix,"generateStats_"+indexStr),cmd,dependencies=dirTask))

Expand Down

0 comments on commit 75b5c38

Please sign in to comment.