hgvs p. for start lost

Illumina · Oct 23, 2020 · bb055b3 · bb055b3
1 parent 53fbf89
commit bb055b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/UnitTests/VariantAnnotation/AnnotatedPositions/HgvspNotationTests.cs b/UnitTests/VariantAnnotation/AnnotatedPositions/HgvspNotationTests.cs
@@ -173,14 +173,14 @@ public void Frameshift_due_to_insertion()
 		//NP_001263627.1:p.(Met1?)
 		public void Start_lost_start_equals_end()
 	    {
-		    Assert.Equal("NP_001263627.1:p.0?", HgvspNotation.GetStartLostNotation("NP_001263627.1", 1, 1, "Met"));
+		    Assert.Equal("NP_001263627.1:p.?", HgvspNotation.GetStartLostNotation("NP_001263627.1", 1, 1, "Met"));
 		}
 
 	    [Fact]
 	    //NP_001263627.1:p.(Met1?)
 	    public void Start_lost_start_not_equals_end()
 	    {
-		    Assert.Equal("NP_001263627.1:p.0?", HgvspNotation.GetStartLostNotation("NP_001263627.1", 1, 3, "Met"));
+		    Assert.Equal("NP_001263627.1:p.?", HgvspNotation.GetStartLostNotation("NP_001263627.1", 1, 3, "Met"));
 	    }
 
 	    [Fact]

diff --git a/VariantAnnotation/AnnotatedPositions/HgvspNotation.cs b/VariantAnnotation/AnnotatedPositions/HgvspNotation.cs
@@ -58,7 +58,7 @@ public static string GetDuplicationNotation(string proteinId, int start, int end
 
         public static string GetStartLostNotation(string proteinId, int start, int end, string refAbbreviation)
         {
-            return $"{proteinId}:p.0?";
+            return $"{proteinId}:p.?";
         }
 
         public static string GetSilentNotation(string hgvscNotation, int start, string refAbbreviation, bool isStopRetained)
@@ -77,6 +77,7 @@ internal static string GetSubstitutionNotation(string proteinId, int start, stri
 
         internal static string GetUnknownNotation(string proteinId, int start, int end, string refAbbreviation, string altAbbreviation)
         {
+
             return start == end
                 ? $"{proteinId}:p.({refAbbreviation}{start}{altAbbreviation})"
                 : $"{proteinId}:p.({refAbbreviation}{start}_{altAbbreviation}{end})";