Add condition to ignore empty bucket

Ilhasoft · Dec 19, 2023 · c783232 · c783232
1 parent d8dbadf
commit c783232
Showing 1 changed file with 18 additions and 14 deletions.
diff --git a/temba/archives/models.py b/temba/archives/models.py
@@ -189,20 +189,24 @@ def iter_records(self, *, where: dict = None):
 
         if where:
             bucket, key = self.get_storage_location()
-            response = s3_client.select_object_content(
-                Bucket=bucket,
-                Key=key,
-                ExpressionType="SQL",
-                Expression=s3.compile_select(where=where),
-                InputSerialization={"CompressionType": "GZIP", "JSON": {"Type": "LINES"}},
-                OutputSerialization={"JSON": {"RecordDelimiter": "\n"}},
-            )
-
-            def generator():
-                for record in EventStreamReader(response["Payload"]):
-                    yield record
-
-            return generator()
+            if bucket == "":
+                return
+
+            else:
+                response = s3_client.select_object_content(
+                    Bucket=bucket,
+                    Key=key,
+                    ExpressionType="SQL",
+                    Expression=s3.compile_select(where=where),
+                    InputSerialization={"CompressionType": "GZIP", "JSON": {"Type": "LINES"}},
+                    OutputSerialization={"JSON": {"RecordDelimiter": "\n"}},
+                )
+
+                def generator():
+                    for record in EventStreamReader(response["Payload"]):
+                        yield record
+
+                return generator()
 
         else:
             bucket, key = self.get_storage_location()