refactor(color): update color function to work with named colors #367
+136
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color function will not work with named colors for keys in a palette. This PR fixes that so an expression like `color($palette, gray, 200)` can still work with palettes where the `gray` variants are keyed to a string.
desig9stein
previously approved these changes
Dec 10, 2024
desig9stein
added
the
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #362
The color function will not work with named colors for keys in a palette. This PR fixes that so an expression like
color($palette, gray, 200)can still work with palettes where thegrayvariants are keyed to a string.This PR DOES NOT fix the underlying issue. Handcrafted palettes should define the keys in the map as strings explicitly, as keys that match named colors will be of type color and will not match map.get calls for strings.
We should make sure this is explained in the docs.