This repository has been archived by the owner on Dec 14, 2017. It is now read-only.
Check automatic refresh interval before refreshing the security tokens. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please approve this. This looks to be a regression since 2.14. We have verified this fixes our performance issues. |
|
I can also verify both the problem and that this PR addresses it. We had an API failing under as few as 50 concurrent users prior to applying this. Once applied, expected throughput was achieved. Please approve. |
ghost
deleted a comment from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for the performance issue found in the DiscoveryDocumentIssuerSecurityTokenProvider when the RetrieveMetadata method is called.
https://github.com/IdentityServer/IdentityServer3.AccessTokenValidation/issues/154