Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup (List/Row)Item #238

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Cleanup (List/Row)Item #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5d9a7
BaseTableRowItem: Make $table param mandantory for constructor
sukhwinder33445 Dec 5, 2024
e33cbce
Remove unused css
sukhwinder33445 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions asset/css/list/item-list.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,3 @@
}
}
}

.controls .list-item:not(:last-child) {
margin-bottom: .5em;
}
10 changes: 3 additions & 7 deletions src/Common/BaseTableRowItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ abstract class BaseTableRowItem extends BaseHtmlElement
/** @var object The associated list item */
protected $item;

/** @var ?BaseItemTable The list where the item is part of */
/** @var BaseItemTable The list where the item is part of */
protected $table;

protected $tag = 'li';
Expand All @@ -25,17 +25,13 @@ abstract class BaseTableRowItem extends BaseHtmlElement
* Create a new table row item
*
* @param object $item
* @param BaseItemTable|null $table
* @param BaseItemTable $table
*/
public function __construct($item, BaseItemTable $table = null)
public function __construct($item, BaseItemTable $table)
{
$this->item = $item;
$this->table = $table;

if ($table === null) {
$this->setTag('div');
}

$this->addAttributes($this->baseAttributes);

$this->init();
Expand Down
Loading