BaseTableRowItem: Use column-content as CSS class
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`content` collides with a container's content and confuses Icinga Web's JS (<2.12.2) which applies `impact` to it, but doesn't remove it sometimes.
nilmerg
force-pushed
the
content-as-class-is-too-ambiguous
branch
from
9fd3651 to
0fedfec
Compare
nilmerg
added a commit
to Icinga/icingadb-web
that referenced
this pull request
Jul 19, 2024
resolves #1027 requires Icinga/ipl-web#227
nilmerg
changed the title
col-content as CSS classcolumn-content as CSS class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contentcollides with a container's content and confuses Icinga Web's JS (<2.12.2) which appliesimpactto it, but doesn't remove it sometimes.