Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TermInput: Support reorder by drag and drop #223

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented May 6, 2024

No description provided.

@nilmerg nilmerg added the enhancement New feature or request label May 6, 2024
@nilmerg nilmerg self-assigned this May 6, 2024
@cla-bot cla-bot bot added the cla/signed label May 6, 2024
@nilmerg nilmerg changed the base branch from main to read-only-term-input May 6, 2024 13:13
@nilmerg nilmerg added this to the v0.10.0 milestone May 6, 2024
@nilmerg nilmerg force-pushed the read-only-term-input branch from bb1f502 to d4b75a6 Compare May 7, 2024 09:21
@nilmerg nilmerg force-pushed the ordered-term-input branch from f550771 to 3b7ef7d Compare May 7, 2024 09:21
@nilmerg nilmerg force-pushed the read-only-term-input branch from d4b75a6 to b070d4a Compare May 7, 2024 09:24
@nilmerg nilmerg force-pushed the ordered-term-input branch from 3b7ef7d to 07144e6 Compare May 7, 2024 09:26
@nilmerg nilmerg force-pushed the read-only-term-input branch from b070d4a to 16b4ad0 Compare May 7, 2024 09:32
@nilmerg nilmerg force-pushed the ordered-term-input branch from 07144e6 to 43927e8 Compare May 7, 2024 09:32
@nilmerg nilmerg force-pushed the read-only-term-input branch from 16b4ad0 to 301e69e Compare May 15, 2024 14:32
@nilmerg nilmerg force-pushed the ordered-term-input branch 2 times, most recently from 6c367cc to a5571d0 Compare May 17, 2024 12:55
@nilmerg nilmerg force-pushed the read-only-term-input branch from 301e69e to 2c9639b Compare May 24, 2024 05:51
@nilmerg nilmerg force-pushed the ordered-term-input branch from a5571d0 to bbf49c5 Compare May 24, 2024 05:51
@nilmerg nilmerg force-pushed the read-only-term-input branch from 2c9639b to 10f822c Compare May 24, 2024 05:57
@nilmerg nilmerg force-pushed the ordered-term-input branch from bbf49c5 to 3e5bf20 Compare May 24, 2024 05:57
@nilmerg nilmerg force-pushed the read-only-term-input branch from 10f822c to b8d7b5b Compare May 29, 2024 06:08
@nilmerg nilmerg force-pushed the ordered-term-input branch from 3e5bf20 to 818b77a Compare May 29, 2024 06:09
Base automatically changed from read-only-term-input to main June 12, 2024 09:15
nilmerg added 3 commits June 12, 2024 11:17
This wasn't a problem prior as the FilterInput overrides
this method and the TermInput doesn't support insertion.
If the DOM isn't updated, it's not going to be reset.
@nilmerg nilmerg force-pushed the ordered-term-input branch from 818b77a to 7cba398 Compare June 12, 2024 09:17
@nilmerg nilmerg merged commit a37ed9a into main Jun 12, 2024
22 checks passed
@nilmerg nilmerg deleted the ordered-term-input branch June 12, 2024 09:21
nilmerg added a commit to Icinga/icinga-notifications-web that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant