Skip to content

Commit

Permalink
Wip: todos and bugs to fix
Browse files Browse the repository at this point in the history
  • Loading branch information
sukhwinder33445 committed Jul 25, 2024
1 parent df1b0ec commit fdb8771
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion asset/js/widget/ActionList.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ define(["../notjQuery"], function ($) {
onClick(event) {
let target = event.currentTarget;

if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) {
if (target.matches('a') && (! target.matches('.subject') || event.ctrlKey || event.metaKey)) { //TODO: don't use icinga specific classes
return true;
}

Expand Down Expand Up @@ -169,6 +169,7 @@ define(["../notjQuery"], function ($) {
if (! this.isMultiSelectable || ! this.isPrimary) {
return;
}
//TODO: remove icinga specific classes, make this function more generic

let activeItemCount = this.getActiveItems().length;
let footer = this.list.closest('.container').querySelector('.footer');
Expand Down Expand Up @@ -534,6 +535,8 @@ define(["../notjQuery"], function ($) {
* @param detailUrl
*/
load(detailUrl = null) {
//TODO: somehow item is deselected when req is canceled and new req is started
//isProcessing is not working as expected
if (! detailUrl) {
let activeItems = this.getActiveItems();
if (activeItems.length) {
Expand Down

0 comments on commit fdb8771

Please sign in to comment.