Setup wizard: Show module dependencies on requirements page #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
requested changes
Jul 26, 2022
modules/setup/application/views/scripts/form/setup-requirements.phtml
Outdated
Show resolved
Hide resolved
sukhwinder33445
force-pushed
the
show-module-dependencies-on-requirments-page
branch
5 times, most recently
from
035104c to
20208a4
Compare
sukhwinder33445
force-pushed
the
show-module-dependencies-on-requirments-page
branch
from
6b2819a to
a2c019e
Compare
nilmerg
requested changes
Jul 27, 2022
modules/setup/library/Setup/Requirement/WebModuleRequirement.php
Outdated
Show resolved
Hide resolved
| use Icinga\Module\Setup\Requirement\SetRequirement; | ||
| use Icinga\Module\Setup\Requirement\WebModuleRequirement; | ||
|
|
||
| class ModuleDependency |
There was a problem hiding this comment.
How does this work? It's not a page nor a wizard.
There was a problem hiding this comment.
setup-requirements.phtml (line 12) gets the wizard and calls getRequirements().
The class ModuleDependency contains only this method, i.e. if no SetupWizard is provided for the current module (e.g. Cube), this class returns module and lib dependencies.
* Also accept array with two values * evaluate() returns true if `$version` is not defined
sukhwinder33445
force-pushed
the
show-module-dependencies-on-requirments-page
branch
2 times, most recently
from
4633c02 to
2e8cc09
Compare
* Enhance class WebLibraryRequirement
sukhwinder33445
force-pushed
the
show-module-dependencies-on-requirments-page
branch
from
f4c3c9c to
136ebab
Compare
|
Note to myself:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4850