Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced dashboards #4114

Closed
wants to merge 0 commits into from
Closed

Enhanced dashboards #4114

wants to merge 0 commits into from

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Mar 26, 2020 •
edited by nilmerg
Loading

resolves #3809

@yhabteab yhabteab requested a review from lippserd March 26, 2020 08:47
@lippserd lippserd removed their request for review March 26, 2020 11:04
@yhabteab yhabteab force-pushed the feature/enhanced-dashboards-#3809 branch 4 times, most recently from e5d7664 to 09179f9 Compare March 27, 2020 16:23
lippserd
lippserd requested changes Apr 1, 2020
View reviewed changes
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/DashletsController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/DashletsController.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/NewDashletsForm.php Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the feature/enhanced-dashboards-#3809 branch 2 times, most recently from c5133fc to 1d4f26b Compare April 3, 2020 10:13
lippserd
lippserd requested changes Apr 3, 2020
View reviewed changes
modules/dashboards/application/controllers/DashletsController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/DashletsController.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Model/Database.php Outdated Show resolved Hide resolved
@nilmerg nilmerg added area/dashboard Affects the dashboard area/modules Affects module support/integration enhancement New feature or improvement labels Apr 8, 2020
@nilmerg nilmerg changed the title Feature/enhanced dashboards #3809 Enhanced dashboards Apr 8, 2020
@yhabteab yhabteab marked this pull request as ready for review April 9, 2020 13:12
@yhabteab yhabteab marked this pull request as draft April 10, 2020 11:52
lippserd
lippserd requested changes Apr 13, 2020
View reviewed changes
modules/dashboards/application/controllers/DashletsController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/IndexController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/IndexController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/IndexController.php Outdated Show resolved Hide resolved
modules/dashboards/application/controllers/IndexController.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Form/DashletForm.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Web/Widget/DashboardWidget.php Outdated Show resolved Hide resolved
modules/dashboards/library/Dashboards/Web/Widget/DashletWidget.php Outdated Show resolved Hide resolved
@lippserd
Copy link
Member

A little note for the default add to dashboard tab: Since we're using the compat controller from the IPL, the tabs are also from IPL. Have a look at ipl/Web/Tabs and how the DashboardAction extension is being added there. I'm sure you'll find a way how to disable that.

@nilmerg nilmerg mentioned this pull request Apr 16, 2020
Open
3 tasks
nilmerg
nilmerg reviewed Apr 17, 2020
View reviewed changes
modules/dashboards/application/controllers/IndexController.php Outdated
Comment on lines 30 to 32
* create Tabs and
* activate the first dashboard from the database when the url doesn't have a parameter
* @return int $id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Eric told you already often enough what to look out for when writing inline documentation? You'll then certainly know what's wrong here. 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, minus the superfluous $id. You've fixed that already 😅

@nilmerg
Copy link
Member

nilmerg commented Apr 20, 2020

Did another test but faced again a few issues preventing me from completing it. Please fix them:

Trying to create a new dashlet without having a dashboard is not possible. The checkbox which lets me enter a name for a new dashboard has no effect:
Bildschirmfoto von 2020-04-20 10-52-11

Even by hot-fixing it and continuing it does not work because the form keeps telling me I have to choose an existing dashboard:
Bildschirmfoto von 2020-04-20 11-00-33

@yhabteab yhabteab force-pushed the feature/enhanced-dashboards-#3809 branch 2 times, most recently from 0cb412a to 709f763 Compare June 13, 2020 12:30
@nilmerg nilmerg mentioned this pull request Jun 17, 2020
Closed
@yhabteab yhabteab closed this Feb 17, 2021
@yhabteab yhabteab force-pushed the feature/enhanced-dashboards-#3809 branch from dc4638e to 712e74b Compare February 17, 2021 16:25
@yhabteab
Copy link
Member Author

Replaced by #4323

@yhabteab yhabteab deleted the feature/enhanced-dashboards-#3809 branch February 4, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg left review comments

@lippserd lippserd lippserd requested changes

Assignees
No one assigned
Labels
area/dashboard Affects the dashboard area/modules Affects module support/integration enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced Dashboards
3 participants
@yhabteab @lippserd @nilmerg