Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a cancel button in modals #5305

Open
nilmerg opened this issue Dec 16, 2024 · 0 comments
Open

Show a cancel button in modals #5305

nilmerg opened this issue Dec 16, 2024 · 0 comments
Labels
enhancement New feature or improvement TBD To be defined - We aren't certain about this yet

Comments

@nilmerg
Copy link
Member

nilmerg commented Dec 16, 2024

This must not depend on the content. e.g. a form in the modal must not be required nor must not the form itself be responsible for the button.

Maybe, we should introduce a control area in modals. In this area, the cancel button is default and always aligned to the left. Any other buttons are aligned to the right. This also has the benefit that buttons are always visible.

The base form class (or the IcingaFormDecorator in the case of ipl\Web) could support this natively. There are already various cases for forms, that provide multipart content. It makes sense to add native support for this. Then forms, that are loaded inside a modal, could target the new control area when rendering buttons.

@nilmerg nilmerg added enhancement New feature or improvement TBD To be defined - We aren't certain about this yet labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement TBD To be defined - We aren't certain about this yet
Projects
None yet
Development

No branches or pull requests

1 participant