Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unintentional closing of a modal #5307

Open
nilmerg opened this issue Dec 16, 2024 · 2 comments
Open

Prevent unintentional closing of a modal #5307

nilmerg opened this issue Dec 16, 2024 · 2 comments
Labels
enhancement New feature or improvement

Comments

@nilmerg
Copy link
Member

nilmerg commented Dec 16, 2024

A modal has currently the following ways to be closed:

  1. Click on the X in the top right
  2. Click anywhere outside the modal
  3. Push the Escape key
  4. Successfully submit a form
  5. Click on the cancel button (Show a cancel button in modals #5305)

Cases 2 and 3 can easily be triggered, without any intention of the user to close the modal.

To prevent this, once a form has been adjusted, both cases shouldn't allow to close the modal anymore.

An alternative would be to ask for confirmation. Though, I'd like to avoid this at all cost.

@nilmerg nilmerg added the enhancement New feature or improvement label Dec 16, 2024
@slalomsk8er
Copy link

slalomsk8er commented Dec 16, 2024

@nilmerg where did you put your Escape key that it "can easily be triggered, without any intention"?
2. Click anywhere outside the modal - this bit me while UX testing the new notification module.

@nilmerg
Copy link
Member Author

nilmerg commented Dec 17, 2024

At the usual location 😉 (This is just another observation made during UX testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants