DbMigration: Break once a correct schema version is found #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have a report for this or how did you notice this? |
Are you just asking out of curiosity or does it matter to you, how did I notice this? No, we don't have any reports on it. I've had this fix for some time in my local stash and can't even remember how I noticed it. |
yhabteab
force-pushed
the
fix-db-migration-hook
branch
from
3cfd8c8 to
673177e
Compare
yhabteab
force-pushed
the
fix-db-migration-hook
branch
from
673177e to
f773891
Compare
sukhwinder33445
approved these changes
May 7, 2024
Essentially, yes. |
raviks789
force-pushed
the
fix-db-migration-hook
branch
from
f773891 to
fb68aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema versions are queried in descending order and limited to 2, and it should be stopped as soon as it has found the first possible version with
successset to true.