Enhance modal form redirects

[yhabteab]

No description provided.

[lippserd]

@yhabteab This is not ready, right?

[yhabteab]

@yhabteab This is not ready, right?

It's ready, but its kind of waiting for Icinga/icingaweb2#5068 to be merged.

[nilmerg]

• the export dropdown isn't usable while the report is loading. (Fixed by css: Content following controls should not overlay them ipl-web#188)
• Apply outline: none to .content.container:focus.

Sidenote:

the tabs should use data-base-target=_main. Otherwise the detail keeps open while switching.

[nilmerg]

LGTM! The referenced Web PR is merged (kind of)

[lippserd]

I don't know if it's related to the framework or the changes here, but as soon as I remove a report, the report list is refreshed twice. The clone action also triggers a refresh, which is not required.

[yhabteab]

I don't know if it's related to the framework or the changes here, but as soon as I remove a report, the report list is refreshed twice.

It's a framework bug.

The clone action also triggers a refresh, which is not required.

By "triggers a refresh" do you mean that the col2 container is updated after the redirection or that the col1 container is refreshed as well?

[nilmerg]

Shouldn't the cloned report be visible in the detail, instead of the source report?

[yhabteab]

Shouldn't the cloned report be visible in the detail, instead of the source report?

No clue 🤷!

[nilmerg]

I'd say so. At least does the refresh of col2 make no sense currently, as nothing changed. And if I clone a report and want to schedule/send it afterwards, I don't have to search for it in the list.

[nilmerg]

Please fix the conflictPlease rebase

[nilmerg]

Oh no, wait. The time frame items still open a modal.

[nilmerg]

Never mind. But please use openInModal where applicable. (As you noted by yourself)