Report: Cast floats explicitly on PHP < 8.0 in CSV exports

fixes #122
Icinga · Jan 24, 2023 · 9134b7a · 9134b7a
1 parent 3a79758
commit 9134b7a
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/library/Reporting/Report.php b/library/Reporting/Report.php
@@ -304,6 +304,7 @@ public function toHtml()
     public function toCsv()
     {
         $timerange = $this->getTimeframe()->getTimerange();
+        $convertFloats = version_compare(PHP_VERSION, '8.0.0', '<');
 
         $csv = [];
 
@@ -314,7 +315,16 @@ public function toCsv()
                 $data = $implementation->getData($timerange, $reportlet->getConfig());
                 $csv[] = array_merge($data->getDimensions(), $data->getValues());
                 foreach ($data->getRows() as $row) {
-                    $csv[] = array_merge($row->getDimensions(), $row->getValues());
+                    $values = $row->getValues();
+                    if ($convertFloats) {
+                        foreach ($values as &$value) {
+                            if (is_float($value)) {
+                                $value = sprintf('%.4F', $value);
+                            }
+                        }
+                    }
+
+                    $csv[] = array_merge($row->getDimensions(), $values);
                 }
 
                 break;