Fix Chrome/Chromium version detection #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Thomas-Gelf what do you think? |
|
I'll have a look at that one. Thanks for the PR! |
|
Can the path to the chrom(e|ium) binary be made user configurable trough the web interface? E.g. on FreeBSD Chromium binary is at /usr/local/bin/chrome, so at the moment I have to change the path in library/Pdfexport/ProvidedHook/Pdfexport.php. |
|
You can do that inside the module's config.ini already, it just lacks the config forms. Try something like this, IIRC: |
Signed-off-by: Eric Lippmann <[email protected]>
lippserd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On RHEL 7, using Chromium PDF Export fails.
This is caused by the version of Chome
Google Chrome 73.0.3683.103which is different from ChromiumChromium 73.0.3683.86 Fedora Project.It should mitigate icingaweb2-module-reporting issue #7.