Skip to content

Commit

Permalink
ConfigurationController: rename 'configuration'...
Browse files Browse the repository at this point in the history
...to 'inspect' and explain what you're seeing
  • Loading branch information
Thomas-Gelf committed Oct 15, 2019
1 parent 8663e46 commit 0e93cf8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
19 changes: 11 additions & 8 deletions application/controllers/ConfigurationController.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,13 @@ public function init()
$this->assertPermission('director/admin');
}


public function indexAction()
public function inspectAction()
{
$this->addTitle('JIRA Configuration')->activateTab();
$this->addTitle('JIRA Inspection')->activateTab();
$this->content()->add(Html::tag('div', ['class' => 'state-hint warning'], $this->translate(
'This page serves no special purpose right now, but gives some insight'
. ' into available projects and Custom Fields'
)));
$this->runFailSafe(function () {
$this->content()->add(new TemplateForm($this->jira()));
});
Expand Down Expand Up @@ -127,12 +130,12 @@ protected function activateTab($name = null)
if ($name === null) {
$name = $this->getRequest()->getActionName();
}
$this->tabs()->add('index', [
'label' => 'Jira Config',
'url' => 'jira/configuration',
])->add('director', [
'label' => 'Director Config',
$this->tabs()->add('director', [
'label' => $this->translate('Director Config'),
'url' => 'jira/configuration/director',
])->add('inspect', [
'label' => $this->translate('Inspect'),
'url' => 'jira/configuration/inspect',
])->activate($name);

return $this;
Expand Down
2 changes: 1 addition & 1 deletion configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
->setIcon('tasks');
$section->add(N_('Issues'))->setUrl('jira/issues');
$section->add(N_('Configuration'))
->setUrl('jira/configuration')
->setUrl('jira/configuration/director')
->setPermission('director/admin');
$this->providePermission('jira/issue/create', $this->translate('Allow to manually create issues'));

0 comments on commit 0e93cf8

Please sign in to comment.