Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IcingaRedis: Don't throw in method isUnavailable #884

Merged
merged 1 commit into from
Sep 27, 2023
Merged

IcingaRedis: Don't throw in method isUnavailable #884

merged 1 commit into from
Sep 27, 2023

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Sep 27, 2023

fixes #883

@nilmerg nilmerg added bug Something isn't working area/view Affects an entire view labels Sep 27, 2023
@nilmerg nilmerg self-assigned this Sep 27, 2023
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 27, 2023
@nilmerg nilmerg requested a review from yhabteab September 27, 2023 07:56
yhabteab
yhabteab reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this has nothing to do with this PR, but accessing the Source tab while Icinga 2 is stopped results in the following stack trace, you may want to fix that here as well.

Bildschirmfoto 2023-09-27 um 10 08 32

@nilmerg
Copy link
Member Author

nilmerg commented Sep 27, 2023

Nope, that doesn't need fixing. The error message is clear enough and without Icinga 2 the view is useless anyway. Just like any other view if the DB is not reachable.

@nilmerg nilmerg merged commit cd41a20 into master Sep 27, 2023
12 checks passed
@nilmerg nilmerg deleted the fix/broken-views-if-redis-is-unavailable-883 branch September 27, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab yhabteab approved these changes

Assignees

@nilmerg nilmerg

Labels
area/view Affects an entire view bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host/Service views are not usable when Redis is unavailable
2 participants
@nilmerg @yhabteab