Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: Fix operator precedence issues #237

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Jul 18, 2024

No description provided.

@nilmerg nilmerg requested a review from ncosta-ic July 18, 2024 11:39
@nilmerg nilmerg self-assigned this Jul 18, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 18, 2024
public/js/notifications.js Outdated Show resolved Hide resolved
@nilmerg nilmerg force-pushed the even-more-robust-browser-api-checks branch from 48651d3 to a357a45 Compare July 18, 2024 11:49
@nilmerg nilmerg requested review from ncosta-ic and removed request for ncosta-ic July 18, 2024 12:17
Copy link
Member

@ncosta-ic ncosta-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I also double-checked the conditions on my Firefox instance (both, http and https) and the checks return the correct values.

@nilmerg nilmerg merged commit c2654c8 into main Jul 18, 2024
22 checks passed
@nilmerg nilmerg deleted the even-more-robust-browser-api-checks branch July 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants