Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending notifications incident history messages #127

Merged
merged 1 commit into from
May 24, 2024

Conversation

yhabteab
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 25, 2023
@yhabteab yhabteab force-pushed the pending-notifications-message branch 2 times, most recently from a65051e to 60f2f03 Compare October 13, 2023 14:21
@julianbrost
Copy link
Collaborator

Note that even though I already merged Icinga/icinga-notifications#99, I didn't really test this PR because the current state doesn't work (presumably due to the change channel references to IDs change) and I can't rebase without conflicts (don't look too bad, but I didn't bother resolving them).

@yhabteab yhabteab force-pushed the pending-notifications-message branch from 60f2f03 to 8fe79c4 Compare October 25, 2023 08:42
@nilmerg nilmerg added this to the Preview #1 milestone Nov 30, 2023
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state must be translatable. The value in the database is not a label.

@yhabteab yhabteab force-pushed the pending-notifications-message branch from 8fe79c4 to 5c50f4b Compare April 26, 2024 14:58
@yhabteab yhabteab requested a review from nilmerg April 26, 2024 15:29
@yhabteab yhabteab force-pushed the pending-notifications-message branch from 5c50f4b to bf026a5 Compare May 6, 2024 10:43
@yhabteab yhabteab requested a review from nilmerg May 6, 2024 10:44
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, there are conflicts

@yhabteab yhabteab force-pushed the pending-notifications-message branch from bf026a5 to be35b80 Compare May 8, 2024 15:13
@yhabteab yhabteab requested a review from nilmerg May 8, 2024 15:13
@nilmerg nilmerg merged commit 2865b35 into main May 24, 2024
22 checks passed
@nilmerg nilmerg deleted the pending-notifications-message branch May 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants