Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESSI-1336] Resolve bugs loading dynamic schema #301

Merged
merged 5 commits into from
Jun 7, 2021

Conversation

aploshay
Copy link
Contributor

@aploshay aploshay commented May 26, 2021

As a preparatory step for satisfying ESSI-1336 (bulkrax CSV import respecting a supplied dynamic_schema_id), resolves 2 allinson_flex issues:

Ways to manually check these fixes:

  • Issue 61 regards how calling work.dynamic_schema always returns the most recent schema. This can be checked in console against an earlier-saved work with an older schema, with work.dynamic_schema_id == work.dynamic_schema.id -- it should return false without the fix, true with it.
  • Issue 63 regards how initializing a work with an older schema would still result in using the most recent schema. This can be checked in console, with work = WorkType.new(dynamic_schema_id: OLDER_ID_VALUE); work.dynamic_schema_id == work.dynamic_schema.id -- it should return false without the fix, true with it.

@dlpierce dlpierce merged commit a5315b6 into master Jun 7, 2021
@dlpierce dlpierce deleted the ESSI-1336_dynamic_schema_bug branch June 7, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants