Skip to content

Commit

Permalink
SASS: Improve visuals of 'ExpertiseSummaryPage'
Browse files Browse the repository at this point in the history
- Use 'background-image' mixin to set the background image.
- Set 'bottom-desktop' parameter to 0 on 'component-code-snippet' mixin.
- Resize cards min-width && max-width.
- Resize font-size of cards and children.
- Set flex-direction to row for the whole page on desktop.

This changes addresses the minor visual issues of the 'ExpertiseSummaryPage'.
  • Loading branch information
ITurres committed Sep 30, 2023
1 parent 87e60fa commit 586f60b
Showing 1 changed file with 18 additions and 12 deletions.
30 changes: 18 additions & 12 deletions src/styles/pages/ExpertiseSummaryPage.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ $dark: colors.$dark;
$font-family-bold: fonts.$font-family-bold;
$font-family-regular: fonts.$font-family-regular;

.bg--container {
background: url('../../assets/images/bg/expertise-page-bg.jpg');
background-size: cover;
background-position: center;
background-repeat: no-repeat;
.expertise-summary-page-bg--container {
@include mixins.background-image(
'../assets/images/bg/expertise-page-bg.jpg',
cover,
center,
no-repeat
);
}

.expertise {
Expand All @@ -29,7 +31,7 @@ $font-family-regular: fonts.$font-family-regular;
// * top
1,
// * bottom
-2 // * bottom-desktop
0 // * bottom-desktop
);

display: flex;
Expand All @@ -38,8 +40,8 @@ $font-family-regular: fonts.$font-family-regular;
min-height: 100vh;

&__card {
min-width: 300px;
max-width: 400px;
min-width: 250px;
max-width: 350px;
margin: 1rem;
padding: 1rem;
border: 2px solid rgba(255, 255, 255, 0.042);
Expand All @@ -51,7 +53,7 @@ $font-family-regular: fonts.$font-family-regular;

h2 {
color: $color1;
font-size: 1.7rem;
font-size: 1.5rem;
font-family: $font-family-bold;
font-style: oblique;
margin: 0.5rem;
Expand All @@ -64,7 +66,7 @@ $font-family-regular: fonts.$font-family-regular;

span {
color: $color2;
font-size: 1.1rem;
font-size: 1rem;
font-family: $font-family-regular;
margin: 0.3rem;
padding: 0.5rem;
Expand All @@ -78,8 +80,8 @@ $font-family-regular: fonts.$font-family-regular;

.square-item {
background-color: $color1;
height: 40px;
width: 40px;
height: 35px;
width: 35px;
margin-top: 1rem;
margin-left: 1rem;
border-radius: 0.5rem;
Expand All @@ -95,6 +97,9 @@ $font-family-regular: fonts.$font-family-regular;
}

@media (min-width: 1366px) {
flex-direction: row;
padding-left: 6rem;

&__card {
h2 {
text-align: end;
Expand All @@ -112,6 +117,7 @@ $font-family-regular: fonts.$font-family-regular;

.squares--container {
justify-content: flex-end;
padding-right: 0.7rem;

.square-item {
border-left: none;
Expand Down

0 comments on commit 586f60b

Please sign in to comment.