-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix pagination for empty chunks #6985
🐛 Fix pagination for empty chunks #6985
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6985 +/- ##
==========================================
+ Coverage 87.02% 87.03% +0.01%
==========================================
Files 1621 1614 -7
Lines 63993 63803 -190
Branches 2035 2035
==========================================
- Hits 55687 55534 -153
+ Misses 7972 7935 -37
Partials 334 334
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you actually add a test for checking when the number of pages is 0?
…carloromeo/osparc-simcore into is6983/fix-pagination-for-no-chunks
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok all good I think I missed it previously. thanks a lot
What do these changes do?
Fix validation issue in case of empty chunks.
See: #6983
Related issue/s
How to test
Dev-ops checklist