Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix pagination for empty chunks #6985

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Dec 20, 2024

What do these changes do?

Fix validation issue in case of empty chunks.

See: #6983

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (68f0b24) to head (ed37dc5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6985      +/-   ##
==========================================
+ Coverage   87.02%   87.03%   +0.01%     
==========================================
  Files        1621     1614       -7     
  Lines       63993    63803     -190     
  Branches     2035     2035              
==========================================
- Hits        55687    55534     -153     
+ Misses       7972     7935      -37     
  Partials      334      334              
Flag Coverage Δ
integrationtests 64.87% <ø> (-10.13%) ⬇️
unittests 85.33% <100.00%> (-0.63%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.55% <100.00%> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.26% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.22% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.41% <ø> (ø)
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.72% <ø> (-0.04%) ⬇️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.33% <ø> (-0.24%) ⬇️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.42% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f0b24...ed37dc5. Read the comment docs.

@giancarloromeo giancarloromeo marked this pull request as ready for review December 20, 2024 09:45
@giancarloromeo giancarloromeo requested a review from GitHK December 20, 2024 09:46
@giancarloromeo giancarloromeo enabled auto-merge (squash) December 20, 2024 10:24
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you actually add a test for checking when the number of pages is 0?

…carloromeo/osparc-simcore into is6983/fix-pagination-for-no-chunks
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok all good I think I missed it previously. thanks a lot

@giancarloromeo giancarloromeo merged commit 493488c into ITISFoundation:master Dec 20, 2024
89 of 93 checks passed
@giancarloromeo giancarloromeo deleted the is6983/fix-pagination-for-no-chunks branch December 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset error when paginating empty chunks
4 participants