Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ introduce webserver rpc endpoints for licenses #6946

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 11, 2024

What do these changes do?

  • ✨ introduce webserver rpc endpoints for licenses
    • these are dummy endpoints, only the get_licensed_items is functional
    • interface between webserver and api server

@bisgaard-itis will implement the api server part

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 11, 2024 13:07
@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 11, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Dec 11, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.72464% with 34 lines in your changes missing coverage. Please review.

Project coverage is 88.14%. Comparing base (ff6f85a) to head (f0614a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6946      +/-   ##
==========================================
+ Coverage   88.12%   88.14%   +0.01%     
==========================================
  Files        1587     1234     -353     
  Lines       62168    52633    -9535     
  Branches     2008      997    -1011     
==========================================
- Hits        54783    46391    -8392     
+ Misses       7050     6048    -1002     
+ Partials      335      194     -141     
Flag Coverage Δ
integrationtests 64.99% <71.42%> (+0.03%) ⬆️
unittests 86.02% <50.72%> (-0.32%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 74.58% <0.00%> (-0.52%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <ø> (ø)
autoscaling 95.42% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.37% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.99% <ø> (ø)
dynamic_sidecar 89.78% <ø> (+0.03%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.65% <ø> (ø)
resource_usage_tracker 89.65% <ø> (+0.33%) ⬆️
storage 89.60% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.75% <100.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6f85a...f0614a0. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 11, 2024 13:19
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot for the quick additions. I will start exposing these on the api-server side

@matusdrobuliak66 matusdrobuliak66 merged commit e94782d into ITISFoundation:master Dec 11, 2024
90 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants