Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💣 Remove osparc-gateway-server and clusters endpoints #6881

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
34d3085
removed osparc-gateway-server
sanderegg Dec 2, 2024
003410b
removed dask-gateway dependency
sanderegg Dec 2, 2024
2fdfcfd
removed dask-gateway(-server)
sanderegg Dec 2, 2024
6515e8a
removed settings for dask-gateway
sanderegg Dec 2, 2024
21efa34
removing occurences of dask-gateway
sanderegg Dec 2, 2024
7c48095
removed clusters endpoint from dv-2
sanderegg Dec 2, 2024
15bee14
removed cluster changes
sanderegg Dec 2, 2024
bd0cf91
cluster selection is gone
sanderegg Dec 2, 2024
b81c113
removed clusters endpoint from webserver
sanderegg Dec 2, 2024
b64a188
removing clusters stuff
sanderegg Dec 2, 2024
7f05645
typo
sanderegg Dec 2, 2024
43a06d2
fix import
sanderegg Dec 2, 2024
b137698
missing ClusterDetails
sanderegg Dec 2, 2024
f780960
removed unused code
sanderegg Dec 2, 2024
f2c2916
fixed tests in ck
sanderegg Dec 2, 2024
ed00efe
removed InternalClusterAuthentication
sanderegg Dec 2, 2024
0586247
removed unnecessary code
sanderegg Dec 2, 2024
7090b4b
removed tests of the cluster
sanderegg Dec 2, 2024
ec1fe55
fixed examples
sanderegg Dec 2, 2024
5504037
fixed dv-2 linter
sanderegg Dec 2, 2024
5e59cd8
removed WEBSERVER_CLUSTERS
sanderegg Dec 2, 2024
1fdc255
removed clusters endpoint from webserver
sanderegg Dec 2, 2024
e9770ec
remove usage of deleted code
sanderegg Dec 2, 2024
3acf258
fix test
sanderegg Dec 3, 2024
ccd7fad
fixed import
sanderegg Dec 3, 2024
298dd60
fixed tests and removed cluster ids
sanderegg Dec 3, 2024
e2862d1
removing cluster information
sanderegg Dec 3, 2024
d588eae
removed cluster_id from scheduler interface
sanderegg Dec 3, 2024
31ca758
removed cluster_id from scheduler interface
sanderegg Dec 3, 2024
0569b19
cleanup
sanderegg Dec 3, 2024
d2e3e8f
updated API
sanderegg Dec 3, 2024
2114064
fixes webserver tests
sanderegg Dec 3, 2024
5665b70
cleanup
sanderegg Dec 3, 2024
b59e531
updated openapi
sanderegg Dec 3, 2024
187db14
use the correct model
sanderegg Dec 3, 2024
8c9dbec
removed all cluster_id occurences
sanderegg Dec 3, 2024
88b1a8e
removed occurences of cluster_id
sanderegg Dec 3, 2024
8fc9cc6
added missing depenedncy
sanderegg Dec 3, 2024
7ac0391
removed unnecessary tests
sanderegg Dec 3, 2024
cfebe07
rename
sanderegg Dec 3, 2024
67e6f9a
cleanup
sanderegg Dec 3, 2024
3e3d90f
fixes and cleanup
sanderegg Dec 3, 2024
9178acf
removed cluster_id
sanderegg Dec 3, 2024
83cd7ba
linter
sanderegg Dec 3, 2024
2ade1cb
real fix
sanderegg Dec 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ component_management:
- component_id: invitations
paths:
- services/invitations/**
- component_id: osparc_gateway_server
paths:
- services/osparc-gateway-server/**
- component_id: payments
paths:
- services/payments/**
Expand Down
3 changes: 0 additions & 3 deletions .env-devel
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ WB_API_WEBSERVER_PORT=8080
WB_GC_ACTIVITY=null
WB_GC_ANNOUNCEMENTS=0
WB_GC_CATALOG=null
WB_GC_CLUSTERS=0
WB_GC_DB_LISTENER=0
WB_GC_DIAGNOSTICS=null
WB_GC_EMAIL=null
Expand Down Expand Up @@ -292,7 +291,6 @@ WB_GC_WALLETS=0
WB_DB_EL_ACTIVITY=null
WB_DB_EL_ANNOUNCEMENTS=0
WB_DB_EL_CATALOG=null
WB_DB_EL_CLUSTERS=0
WB_DB_EL_DB_LISTENER=1
WB_DB_EL_DIAGNOSTICS=null
WB_DB_EL_EMAIL=null
Expand Down Expand Up @@ -359,7 +357,6 @@ TWILIO_COUNTRY_CODES_W_ALPHANUMERIC_SID_SUPPORT=["41"]
WEBSERVER_ACTIVITY=null
WEBSERVER_ANNOUNCEMENTS=1
WEBSERVER_CATALOG={}
WEBSERVER_CLUSTERS=0
WEBSERVER_CREDIT_COMPUTATION_ENABLED=1
WEBSERVER_DB_LISTENER=0
WEBSERVER_DEV_FEATURES_ENABLED=0
Expand Down
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ Makefile @pcrespov @sanderegg
/services/efs-guardian/ @matusdrobuliak66
/services/invitations/ @pcrespov
/services/migration/ @pcrespov
/services/osparc-gateway-server/ @sanderegg
/services/payments/ @pcrespov @matusdrobuliak66
/services/resource-usage-tracker/ @matusdrobuliak66
/services/static-webserver/ @GitHK
Expand Down
145 changes: 0 additions & 145 deletions .github/workflows/ci-testing-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ jobs:
efs-guardian: ${{ steps.filter.outputs.efs-guardian }}
invitations: ${{ steps.filter.outputs.invitations }}
migration: ${{ steps.filter.outputs.migration }}
osparc-gateway-server: ${{ steps.filter.outputs.osparc-gateway-server }}
payments: ${{ steps.filter.outputs.payments }}
dynamic-scheduler: ${{ steps.filter.outputs.dynamic-scheduler }}
resource-usage-tracker: ${{ steps.filter.outputs.resource-usage-tracker }}
Expand Down Expand Up @@ -222,12 +221,6 @@ jobs:
- 'packages/**'
- 'services/migration/**'
- 'services/docker-compose*'
osparc-gateway-server:
- 'packages/**'
- 'services/osparc-gateway-server/**'
- 'services/docker-compose*'
- 'scripts/mypy/*'
- 'mypy.ini'
payments:
- 'packages/**'
- 'services/payments/**'
Expand Down Expand Up @@ -1161,64 +1154,6 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

unit-test-osparc-gateway-server:
needs: changes
if: ${{ needs.changes.outputs.osparc-gateway-server == 'true' || github.event_name == 'push' }}
timeout-minutes: 18 # if this timeout gets too small, then split the tests
name: "[unit] osparc-gateway-server"
runs-on: ${{ matrix.os }}
strategy:
matrix:
python: ["3.11"]
os: [ubuntu-22.04]
fail-fast: false
steps:
- uses: actions/checkout@v4
- name: setup docker buildx
id: buildx
uses: docker/setup-buildx-action@v3
with:
driver: docker-container
- name: setup python environment
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
- name: install uv
uses: astral-sh/setup-uv@v4
with:
version: "0.4.x"
enable-cache: false
cache-dependency-glob: "**/osparc-gateway-server/requirements/ci.txt"
- name: show system version
run: ./ci/helpers/show_system_versions.bash
- name: install
run: |
make devenv
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make install-ci
- name: typecheck
run: |
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make mypy
- name: test
if: ${{ !cancelled() }}
run: |
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make test-ci-unit
- uses: codecov/[email protected]
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
flags: unittests #optional
- name: Upload test results to Codecov
if: ${{ !cancelled() }}
uses: codecov/test-results-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}

unit-test-payments:
needs: changes
if: ${{ needs.changes.outputs.payments == 'true' || github.event_name == 'push' }}
Expand Down Expand Up @@ -1965,7 +1900,6 @@ jobs:
unit-test-models-library,
unit-test-common-library,
unit-test-notifications-library,
unit-test-osparc-gateway-server,
unit-test-payments,
unit-test-dynamic-scheduler,
unit-test-postgres-database,
Expand Down Expand Up @@ -2317,84 +2251,6 @@ jobs:
with:
flags: integrationtests #optional

integration-test-osparc-gateway-server:
needs: [changes, build-test-images]
if: ${{ needs.changes.outputs.anything-py == 'true' || needs.changes.outputs.osparc-gateway-server == 'true' || github.event_name == 'push' }}
timeout-minutes: 30 # if this timeout gets too small, then split the tests
name: "[int] osparc-gateway-server"
runs-on: ${{ matrix.os }}
strategy:
matrix:
python: ["3.11"]
os: [ubuntu-22.04]
fail-fast: false
steps:
- uses: actions/checkout@v4
- name: setup docker buildx
id: buildx
uses: docker/setup-buildx-action@v3
with:
driver: docker-container

- name: setup python environment
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
- name: expose github runtime for buildx
uses: crazy-max/ghaction-github-runtime@v3
# FIXME: Workaround for https://github.com/actions/download-artifact/issues/249
- name: download docker images with retry
uses: Wandalen/wretry.action@master
with:
action: actions/download-artifact@v4
with: |
name: docker-buildx-images-${{ runner.os }}-${{ github.sha }}
path: /${{ runner.temp }}/build
attempt_limit: 5
attempt_delay: 1000
- name: load docker images
run: make load-images local-src=/${{ runner.temp }}/build
- name: install uv
uses: astral-sh/setup-uv@v4
with:
version: "0.4.x"
enable-cache: false
cache-dependency-glob: "**/osparc-gateway-server/requirements/ci.txt"
- name: show system version
run: ./ci/helpers/show_system_versions.bash
- name: install
run: |
make devenv && \
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make install-ci
- name: integration-test
run: |
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make test-ci-integration
- name: system-test
run: |
source .venv/bin/activate && \
pushd services/osparc-gateway-server && \
make test-system
- name: upload failed tests logs
if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4
with:
name: ${{ github.job }}_docker_logs
path: ./services/director-v2/test_failures
- name: cleanup
if: ${{ !cancelled() }}
run: |
pushd services/osparc-gateway-server && \
make down
- uses: codecov/[email protected]
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
flags: integrationtests #optional

integration-test-simcore-sdk:
needs: [changes, build-test-images]
if: ${{ needs.changes.outputs.anything-py == 'true' || needs.changes.outputs.simcore-sdk == 'true' || github.event_name == 'push' }}
Expand Down Expand Up @@ -2466,7 +2322,6 @@ jobs:
integration-test-director-v2-01,
integration-test-director-v2-02,
integration-test-dynamic-sidecar,
integration-test-osparc-gateway-server,
integration-test-simcore-sdk,
integration-test-webserver-01,
integration-test-webserver-02,
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ SERVICES_NAMES_TO_BUILD := \
efs-guardian \
invitations \
migration \
osparc-gateway-server \
payments \
resource-usage-tracker \
dynamic-scheduler \
Expand Down
104 changes: 0 additions & 104 deletions api/specs/web-server/_cluster.py

This file was deleted.

8 changes: 3 additions & 5 deletions api/specs/web-server/_computations.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
from fastapi import APIRouter, status
from models_library.api_schemas_directorv2.comp_tasks import ComputationGet
from models_library.api_schemas_webserver.computations import ComputationStart
from models_library.generics import Envelope
from models_library.projects import ProjectID
from simcore_service_webserver._meta import API_VTAG
from simcore_service_webserver.director_v2._handlers import (
ComputationTaskGet,
_ComputationStarted,
)
from simcore_service_webserver.director_v2._handlers import _ComputationStarted

router = APIRouter(
prefix=f"/{API_VTAG}",
Expand All @@ -19,7 +17,7 @@

@router.get(
"/computations/{project_id}",
response_model=Envelope[ComputationTaskGet],
response_model=Envelope[ComputationGet],
)
async def get_computation(project_id: ProjectID):
...
Expand Down
1 change: 0 additions & 1 deletion api/specs/web-server/openapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"_announcements",
"_catalog",
"_catalog_tags", # MUST BE after _catalog
"_cluster",
"_computations",
"_exporter",
"_folders",
Expand Down
Loading
Loading