Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ introduce search parameter to the listing workspaces #6872

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 29, 2024

What do these changes do?

  • ✨ introduce search parameter to the listing workspaces

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 29, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Nov 29, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (0c5a068) to head (02bebcc).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0c5a068) and HEAD (02bebcc). Click for more details.

HEAD has 27 uploads less than BASE
Flag BASE (0c5a068) HEAD (02bebcc)
unittests 31 4
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6872      +/-   ##
==========================================
- Coverage   88.38%   82.30%   -6.09%     
==========================================
  Files        1561      627     -934     
  Lines       62397    31120   -31277     
  Branches     2108      318    -1790     
==========================================
- Hits        55149    25612   -29537     
+ Misses       6917     5448    -1469     
+ Partials      331       60     -271     
Flag Coverage Δ
integrationtests 64.91% <66.66%> (-0.13%) ⬇️
unittests 87.19% <100.00%> (+0.85%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.13% <ø> (-13.54%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.86%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.66% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5a068...02bebcc. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 29, 2024 16:21
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link

sonarqubecloud bot commented Dec 2, 2024

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 2, 2024 13:02
@matusdrobuliak66 matusdrobuliak66 merged commit 931595e into ITISFoundation:master Dec 2, 2024
85 of 90 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the add-search-to-workspaces branch December 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seach workspaces
6 participants