Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 api-server's LogStreamerRegistionConflictError not logged as a server error anymore #6856

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 27, 2024

What do these changes do?

  • api-server's LogStreamerRegistionConflictError is a client error and must not be logged as a server error.

Related issue/s

How to test

Dev-ops checklist

None

@pcrespov pcrespov changed the title Is6714/logstream log 🎨 api-server's LogStreamerRegistionConflictError not logged as exception anymore Nov 27, 2024
@pcrespov pcrespov self-assigned this Nov 27, 2024
@pcrespov pcrespov added the a:apiserver api-server service label Nov 27, 2024
@pcrespov pcrespov marked this pull request as ready for review November 27, 2024 21:07
@pcrespov pcrespov enabled auto-merge (squash) November 27, 2024 21:07
@pcrespov pcrespov requested review from sanderegg, bisgaard-itis and matusdrobuliak66 and removed request for sanderegg November 27, 2024 21:07
@pcrespov pcrespov changed the title 🎨 api-server's LogStreamerRegistionConflictError not logged as exception anymore 🎨 api-server's LogStreamerRegistionConflictError not logged as a server error anymore Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.83%. Comparing base (a6d944f) to head (eab86c0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a6d944f) and HEAD (eab86c0). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (a6d944f) HEAD (eab86c0)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6856       +/-   ##
===========================================
- Coverage   88.01%   66.83%   -21.19%     
===========================================
  Files        1538      699      -839     
  Lines       61474    33687    -27787     
  Branches     2166      318     -1848     
===========================================
- Hits        54108    22515    -31593     
- Misses       7035    11112     +4077     
+ Partials      331       60      -271     
Flag Coverage Δ
integrationtests 64.78% <ø> (+11.44%) ⬆️
unittests 89.72% <66.66%> (+3.45%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server 89.72% <66.66%> (+<0.01%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.53% <ø> (-14.61%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.59% <ø> (-27.92%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d944f...eab86c0. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@pcrespov pcrespov force-pushed the is6714/logstream-log branch from 9eacf39 to eab86c0 Compare November 28, 2024 10:44
@pcrespov pcrespov merged commit c85f825 into ITISFoundation:master Nov 28, 2024
84 of 90 checks passed
@pcrespov pcrespov deleted the is6714/logstream-log branch November 28, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log logstreaming errors as warnings in api-server
3 participants