Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 webserver's trash flag #6850

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 27, 2024

What do these changes do?

  • Adds WEBSERVER_TRASH flag to indicate whether the trash functionality is available or not.
  • Since currently it is under development, it is aliased to WEBSERVER_DEV_FEATURES_ENABLED
  • The front-end can get this information via GET /static-frontend-data.json
    image

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/isolated -k test_settings_to_client_statics_for_webserver_trash.py

Dev-ops

None

@pcrespov pcrespov self-assigned this Nov 27, 2024
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.59%. Comparing base (83a08e7) to head (7373242).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6850      +/-   ##
==========================================
+ Coverage   88.38%   88.59%   +0.20%     
==========================================
  Files        1550      619     -931     
  Lines       61763    30922   -30841     
  Branches     2166      318    -1848     
==========================================
- Hits        54588    27394   -27194     
+ Misses       6844     3468    -3376     
+ Partials      331       60     -271     
Flag Coverage Δ
integrationtests 64.76% <100.00%> (-0.01%) ⬇️
unittests 87.16% <100.00%> (+0.86%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.04% <ø> (-0.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.59% <ø> (-0.16%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.68% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a08e7...7373242. Read the comment docs.

@pcrespov pcrespov changed the title WIP: Is468/trash enable flag 🎨 webserver's trash flag Nov 27, 2024
@pcrespov pcrespov marked this pull request as ready for review November 27, 2024 11:45
@pcrespov pcrespov requested a review from odeimaiz November 27, 2024 11:45
@pcrespov pcrespov mentioned this pull request Nov 27, 2024
1 task
@pcrespov pcrespov added this to the Event Horizon milestone Nov 27, 2024
@pcrespov pcrespov mentioned this pull request Nov 27, 2024
1 task
@pcrespov pcrespov enabled auto-merge (squash) November 27, 2024 12:26
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pcrespov pcrespov merged commit 4160ba3 into ITISFoundation:master Nov 27, 2024
84 of 90 checks passed
@pcrespov pcrespov deleted the is468/trash-enable-flag branch November 27, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants