Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improving E2E tests: expected_service_running #6739

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • 🎨 Improving E2E Tests: Enhance the method for determining whether a service is running (expected_service_running). The service is considered running either when this information is received via socketio or when a 200 response is returned from the service endpoint (as the frontend does).

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 Improving E2E tests: Polling for service status 🎨 Improving E2E tests: expected_service_running Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 18, 2024 07:59
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 added the e2e Bugs found by or related to the end-2-end testing label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (7ec1d25) to head (f4ba833).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6739      +/-   ##
==========================================
+ Coverage   87.74%   87.76%   +0.01%     
==========================================
  Files        1570     1563       -7     
  Lines       63322    63121     -201     
  Branches     2119     2119              
==========================================
- Hits        55564    55396     -168     
+ Misses       7431     7398      -33     
  Partials      327      327              
Flag Coverage Δ
integrationtests 64.88% <ø> (-0.04%) ⬇️
unittests 85.71% <ø> (+<0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 92.01% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.33% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.50% <ø> (ø)
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 96.98% <ø> (ø)
api_server 89.88% <ø> (ø)
autoscaling 95.22% <ø> (ø)
catalog 89.42% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.80% <ø> (-0.13%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.78% <ø> (ø)
efs_guardian 90.01% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.41% <ø> (+0.26%) ⬆️
payments 92.87% <ø> (ø)
resource_usage_tracker 90.80% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec1d25...f4ba833. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added a few comments

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The frontend doesn't strictly expect a 200 to determine that the backend is ready. If the response status is less than 400, it means that the backend is ready (I believe that there are some services that respond with a 3XX)

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 18, 2024 10:06
@matusdrobuliak66 matusdrobuliak66 merged commit c83d60c into ITISFoundation:master Nov 18, 2024
88 of 89 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the enhance-e2e-tests branch November 18, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants