-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improving E2E tests: expected_service_running
#6739
🎨 Improving E2E tests: expected_service_running
#6739
Conversation
expected_service_running
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6739 +/- ##
==========================================
+ Coverage 87.74% 87.76% +0.01%
==========================================
Files 1570 1563 -7
Lines 63322 63121 -201
Branches 2119 2119
==========================================
- Hits 55564 55396 -168
+ Misses 7431 7398 -33
Partials 327 327
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, added a few comments
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend doesn't strictly expect a 200 to determine that the backend is ready. If the response status is less than 400, it means that the backend is ready (I believe that there are some services that respond with a 3XX)
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
c83d60c
into
ITISFoundation:master
What do these changes do?
expected_service_running
). The service is considered running either when this information is received via socketio or when a 200 response is returned from the service endpoint (as the frontend does).Related issue/s
How to test
Dev-ops checklist