Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️♻️ Upgrades pint library as well as Dockerfile syntax to address deprecation or syntax warnings #6521

Merged
merged 15 commits into from
Oct 15, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 13, 2024

What do these changes do?

This PR addresses multiple warnings notified while running tests

  • Fixes minor warning in Dockerfiles:
[FromAsCasing: 'as' and 'FROM' keywords' casing do not match default app
  • Fixes deprecation warning by upgrading pint
/.venv/lib/python3.11/site-packages/pint/parser.py:264: DeprecationWarning: path is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.
    with resources.path(__package__, resource_name) as p:

Upgrades summary

  • #packages before ~ 5
  • #packages after ~ 7
# name before after upgrade count packages
1 dataclasses 0.7 🗑️ removed 1 director🔧
2 importlib-metadata 2.0.0 🗑️ removed 1 director🔧
3 pint 0.19.2, 0.23 0.24.3 minor 4 api-server⬆️
director-v2⬆️
dynamic-sidecar⬆️
web⬆️
4 redis 5.0.8 5.0.4 🔥 downgrade 6 agent⬆️
aws-library🧪
payments⬆️
service-library🧪
simcore-sdk🧪
swarm-deploy🧪
5 zipp 3.4.0 🗑️ removed 1 director🔧

Legend:

  • ⬆️ base dependency (only services because packages are floating)
  • 🧪 test dependency
  • 🔧 tool dependency

Related issue/s

Maintenance: test warnings

How to test

in place

Dev-ops checklist

None

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Oct 13, 2024
@pcrespov pcrespov self-assigned this Oct 13, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 13, 2024
@pcrespov pcrespov marked this pull request as ready for review October 13, 2024 10:22
@pcrespov pcrespov enabled auto-merge (squash) October 13, 2024 10:22
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.0%. Comparing base (cafbf96) to head (a3b4112).
Report is 635 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6521      +/-   ##
=========================================
+ Coverage    84.5%   86.0%    +1.4%     
=========================================
  Files          10    1507    +1497     
  Lines         214   62470   +62256     
  Branches       25    1936    +1911     
=========================================
+ Hits          181   53737   +53556     
- Misses         23    8440    +8417     
- Partials       10     293     +283     
Flag Coverage Δ
unittests 86.0% <100.0%> (+1.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...r/src/simcore_service_webserver/catalog/_models.py 90.3% <100.0%> (ø)

... and 1456 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as draft October 13, 2024 10:26
auto-merge was automatically disabled October 13, 2024 10:26

Pull request was converted to draft

@pcrespov pcrespov changed the title ⬆️♻️ Upgrades pint library and Dockerfile syntax to address warnings WIP ⬆️♻️ Upgrades pint and redis libraries as well as Dockerfile syntax to address deprecation or syntax warnings Oct 13, 2024
@pcrespov pcrespov marked this pull request as ready for review October 14, 2024 08:35
@pcrespov pcrespov changed the title WIP ⬆️♻️ Upgrades pint and redis libraries as well as Dockerfile syntax to address deprecation or syntax warnings ⬆️♻️ Upgrades pint and redis libraries as well as Dockerfile syntax to address deprecation or syntax warnings Oct 14, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@pcrespov pcrespov changed the title ⬆️♻️ Upgrades pint and redis libraries as well as Dockerfile syntax to address deprecation or syntax warnings ⬆️♻️ Upgrades pint library as well as Dockerfile syntax to address deprecation or syntax warnings Oct 15, 2024
@pcrespov pcrespov enabled auto-merge (squash) October 15, 2024 08:57
@pcrespov pcrespov disabled auto-merge October 15, 2024 13:44
@pcrespov pcrespov merged commit 2e1f0ec into ITISFoundation:master Oct 15, 2024
35 of 36 checks passed
@pcrespov pcrespov deleted the mai/update-pynt branch October 15, 2024 13:44
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants