Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 notify frontend about current efs disk space #6520

Merged
merged 14 commits into from
Oct 29, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 11, 2024

What do these changes do?

  • 🎨 notify frontend about current efs disk space
  • @odeimaiz lets check this one together ;)

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.25%. Comparing base (1067924) to head (3320141).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1067924) and HEAD (3320141). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (1067924) HEAD (3320141)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6520       +/-   ##
===========================================
- Coverage   87.84%   65.25%   -22.59%     
===========================================
  Files        1561      634      -927     
  Lines       62760    31441    -31319     
  Branches     2085      265     -1820     
===========================================
- Hits        55129    20516    -34613     
- Misses       7313    10864     +3551     
+ Partials      318       61      -257     
Flag Coverage Δ
integrationtests 64.80% <ø> (ø)
unittests 89.96% <94.00%> (+3.42%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.22% <ø> (-14.52%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.70% <ø> (-30.01%) ⬇️
efs_guardian 89.96% <94.00%> (+2.93%) ⬆️
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.76% <ø> (-29.56%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1067924...3320141. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 11, 2024 14:39
@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 11, 2024
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are now free to recreate the PR or a new one based on my changes from. You have details on how to use the RPC interface in the description of #6536

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 29, 2024 15:42
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit c0b276a into ITISFoundation:master Oct 29, 2024
82 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants