Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ⬆️ Upgrade web server (Pydantic v2) #6515

Conversation

giancarloromeo
Copy link
Contributor

What do these changes do?

Upgrade the WEB server (to Pydantic v2).

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Oct 10, 2024
@giancarloromeo giancarloromeo added this to the MartinKippenberger milestone Oct 10, 2024
@giancarloromeo giancarloromeo self-assigned this Oct 10, 2024
@giancarloromeo giancarloromeo changed the base branch from master to pydantic_v2_migration October 10, 2024 16:21
@giancarloromeo giancarloromeo changed the title WIP: Upgrade web server WIP: ⬆️ Upgrade web server Oct 10, 2024
@giancarloromeo giancarloromeo changed the title WIP: ⬆️ Upgrade web server WIP: ⬆️ Upgrade web server (Pydantic v2) Oct 10, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration@5528772). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/src/simcore_postgres_database/models/products.py 50.0% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             pydantic_v2_migration   #6515   +/-   ##
=======================================================
  Coverage                         ?   79.3%           
=======================================================
  Files                            ?     390           
  Lines                            ?   13506           
  Branches                         ?     949           
=======================================================
  Hits                             ?   10717           
  Misses                           ?    2620           
  Partials                         ?     169           
Flag Coverage Δ
unittests 79.3% <66.6%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/models_library/api_schemas_payments/errors.py 96.0% <100.0%> (ø)
...ages/settings-library/src/settings_library/base.py 89.2% <ø> (ø)
...e/src/simcore_postgres_database/models/products.py 95.7% <50.0%> (ø)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@sanderegg sanderegg deleted the branch ITISFoundation:pydantic_v2_migration October 22, 2024 21:29
@sanderegg sanderegg closed this Oct 22, 2024
@giancarloromeo giancarloromeo deleted the is4481/upgrade-web-server branch November 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major upgrade to pydantic 2.0
2 participants