⬆️ Upgrade API server (Pydantic v2) #6511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration #6511 +/- ##
=======================================================
Coverage ? 84.1%
=======================================================
Files ? 847
Lines ? 30043
Branches ? 1809
=======================================================
Hits ? 25290
Misses ? 4452
Partials ? 301
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giancarloromeo
commented
Oct 22, 2024
| @@ -25,10 +25,6 @@ define _create_and_validate_openapi | |||
| export API_SERVER_DEV_FEATURES_ENABLED=$1; \ | |||
| python3 -c "import json; from $(APP_PACKAGE_NAME).main import *; print( json.dumps(the_app.openapi(), indent=2) )" > $@ | |||
|
|
|||
| # patching version until tools adapted | |||
| @sed -i 's/"openapi": "3.1.0",/"openapi": "3.0.2",/g' $@ | |||
There was a problem hiding this comment.
Not needed anymore
giancarloromeo
commented
Oct 22, 2024
| @@ -15,8 +15,8 @@ reqs: ## compiles pip requirements (.in -> .txt) | |||
|
|
|||
|
|
|||
| # specification of the used openapi-generator-cli (see also https://github.com/ITISFoundation/openapi-generator) | |||
| OPENAPI_GENERATOR_NAME := itisfoundation/openapi-generator-cli-openapi-generator-v4.2.3 | |||
| OPENAPI_GENERATOR_TAG := v0 | |||
| OPENAPI_GENERATOR_NAME := openapitools/openapi-generator-cli | |||
There was a problem hiding this comment.
Official tool used for validation
|
giancarloromeo
changed the title
giancarloromeo
requested review from
sanderegg,
pcrespov and
matusdrobuliak66
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
They upgrade the API server (Pydantic v2).
Related issue/s
How to test
Dev-ops checklist