Upgrade agent service (Pydantic v2) #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration #6508 +/- ##
=======================================================
Coverage ? 97.8%
=======================================================
Files ? 13
Lines ? 324
Branches ? 0
=======================================================
Hits ? 317
Misses ? 7
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giancarloromeo
commented
Oct 10, 2024
| @@ -187,9 +188,8 @@ def caplog_info_debug( | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="module") | |||
| def mocked_s3_server_url(mocked_aws_server: ThreadedMotoServer) -> HttpUrl: | |||
| def mocked_s3_server_url(mocked_aws_server: ThreadedMotoServer) -> HttpUrlLegacy: | |||
There was a problem hiding this comment.
This HttpUrlLegacy has been introduced to be compliant with the previous HttpUrl (Pydantic v1). It solves the issue with the trailing slash.
giancarloromeo
changed the title
giancarloromeo
requested review from
pcrespov,
sanderegg and
matusdrobuliak66
matusdrobuliak66
approved these changes
Oct 10, 2024
pcrespov
approved these changes
Oct 10, 2024
| # via pydantic | ||
| fastapi==0.96.0 | ||
| fastapi==0.115.0 |
There was a problem hiding this comment.
OK so we also upgrade fastapi to the latest?
GitHK
approved these changes
Oct 10, 2024
giancarloromeo
merged commit 329b00d
into
ITISFoundation:pydantic_v2_migration
54 of 58 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Upgrades the agent service to Pydantic v2.
Related issue/s
How to test
Dev-ops checklist