Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Autoscaling in computational clusters could not start without SSM parameters #6229

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 23, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:autoscaling autoscaling service in simcore's stack label Aug 23, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 23, 2024
@sanderegg sanderegg self-assigned this Aug 23, 2024
Copy link

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.8%. Comparing base (cafbf96) to head (161481c).
Report is 466 commits behind head on master.

Files Patch % Lines
...e_service_autoscaling/modules/auto_scaling_core.py 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6229      +/-   ##
=========================================
- Coverage    84.5%   66.8%   -17.8%     
=========================================
  Files          10     608     +598     
  Lines         214   31433   +31219     
  Branches       25     260     +235     
=========================================
+ Hits          181   21012   +20831     
- Misses         23   10361   +10338     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 96.3% <0.0%> (+11.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e_service_autoscaling/modules/auto_scaling_core.py 92.5% <0.0%> (ø)

... and 617 files with indirect coverage changes

@sanderegg sanderegg merged commit fedc582 into ITISFoundation:master Aug 23, 2024
56 checks passed
@sanderegg sanderegg deleted the bugfix/computational-autoscaling-not-starting branch August 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaling: computational autoscaling does not get the SSM settings and fails
1 participant