-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix services:access endpoint for product group #6213
🐛 fix services:access endpoint for product group #6213
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6213 +/- ##
=========================================
- Coverage 84.5% 82.1% -2.5%
=========================================
Files 10 577 +567
Lines 214 29430 +29216
Branches 25 234 +209
=========================================
+ Hits 181 24175 +23994
- Misses 23 5195 +5172
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeeeeeeeeeeeah. 🎉 🎉 🎉
Also see the same case on fogbugz (we should tag it properly when this one goes to staging): https://z43.manuscript.com/f/cases/202180/Wrong-message-when-sharing-a-project-on-sim4life-io-science
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls create a test that reproduces #1540?
The test should fail with the previous version and pass with your fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good, if that is an expected behavior, that there is a test for it. Otherwise anyone might inadvertently break it.
services/web/server/src/simcore_service_webserver/projects/_nodes_handlers.py
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Thanks! |
What do these changes do?
list_all_user_groups
tolist_user_groups_with_read_access
. The new function,list_all_user_groups
, now correctly returns all groups of the user.Related issue/s
How to test
pytest tests/unit/with_dbs/02/test_projects_nodes_handlers__services_access.py
Dev-ops checklist