-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Mypy: webserver #6193
♻️Mypy: webserver #6193
Conversation
78bf792
to
353a6ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, greatly appreciated!
b971cd6
to
e0f1a9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking care of some errors here.
Please find some minor concerns below.
packages/models-library/src/models_library/projects_nodes_io.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/groups/models.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/statics/_events.py
Outdated
Show resolved
Hide resolved
883dd79
to
94f7c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
c3d808e
to
4dbfc38
Compare
ec10e5a
to
d226b4f
Compare
Quality Gate passedIssues Measures |
What do these changes do?
remaining 125 errors.
Please have a look at logging_utils.py... as it was a bit painful
Related issue/s
How to test
Dev-ops checklist