Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Mypy: webserver #6193

Merged
merged 36 commits into from
Aug 19, 2024
Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 15, 2024

What do these changes do?

remaining 125 errors.

Please have a look at logging_utils.py... as it was a bit painful

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Aug 15, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 15, 2024
@sanderegg sanderegg self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 88.73874% with 25 lines in your changes missing coverage. Please review.

Project coverage is 88.0%. Comparing base (cafbf96) to head (d226b4f).
Report is 448 commits behind head on master.

Files Patch % Lines
...erver/src/simcore_service_webserver/email/_core.py 46.6% 8 Missing ⚠️
...es/service-library/src/servicelib/logging_utils.py 94.1% 2 Missing ⚠️
...src/simcore_service_webserver/catalog/_handlers.py 33.3% 2 Missing ⚠️
...rvices/catalog/src/simcore_service_catalog/main.py 0.0% 1 Missing ⚠️
...service_director_v2/api/routes/dynamic_services.py 50.0% 1 Missing ⚠️
...nvitations/src/simcore_service_invitations/main.py 0.0% 1 Missing ⚠️
...ervices/storage/src/simcore_service_storage/cli.py 0.0% 1 Missing ⚠️
...r/src/simcore_service_webserver/catalog/_models.py 75.0% 1 Missing ⚠️
...simcore_service_webserver/diagnostics/_handlers.py 0.0% 1 Missing ⚠️
.../src/simcore_service_webserver/groups/_handlers.py 0.0% 1 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6193      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.5%     
=========================================
  Files          10    1315    +1305     
  Lines         214   57084   +56870     
  Branches       25    1134    +1109     
=========================================
+ Hits          181   50289   +50108     
- Misses         23    6549    +6526     
- Partials       10     246     +236     
Flag Coverage Δ
integrationtests 64.9% <59.0%> (?)
unittests 85.9% <88.7%> (+1.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/models-library/src/models_library/basic_types.py 98.5% <100.0%> (ø)
...odels-library/src/models_library/projects_nodes.py 90.1% <100.0%> (ø)
...ls-library/src/models_library/projects_nodes_io.py 96.9% <100.0%> (ø)
...rary/src/servicelib/aiohttp/requests_validation.py 87.5% <100.0%> (ø)
...gent/src/simcore_service_agent/core/application.py 100.0% <100.0%> (ø)
...src/simcore_service_api_server/core/application.py 96.8% <100.0%> (ø)
...pi_server/services/solver_job_models_converters.py 97.1% <100.0%> (ø)
...utoscaling/src/simcore_service_autoscaling/main.py 100.0% <100.0%> (ø)
...keeper/src/simcore_service_clusters_keeper/main.py 100.0% <100.0%> (ø)
...-sidecar/src/simcore_service_dask_sidecar/tasks.py 92.5% <100.0%> (ø)
... and 72 more

... and 1224 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review August 15, 2024 14:44
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, greatly appreciated!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of some errors here.
Please find some minor concerns below.

@sanderegg sanderegg force-pushed the mypy/webserver branch 2 times, most recently from 883dd79 to 94f7c97 Compare August 19, 2024 07:44
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sanderegg sanderegg force-pushed the mypy/webserver branch 3 times, most recently from c3d808e to 4dbfc38 Compare August 19, 2024 12:13
Copy link

@sanderegg sanderegg enabled auto-merge (squash) August 19, 2024 14:58
@sanderegg sanderegg merged commit 95e54ff into ITISFoundation:master Aug 19, 2024
68 checks passed
@sanderegg sanderegg deleted the mypy/webserver branch August 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants