Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ web-api: Updated catalog interface and drafted performance test for pagination #6189

Merged
merged 18 commits into from
Aug 20, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 14, 2024

What do these changes do?

  • Changes in web-api (upgraded to v0.42.0)
    • ♻️ Drops /dev and replaces old entrypoints
    • ⚰️ removes old handlers
      image
  • ✅ Drafts tests to load pages to evaluate performance

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov self-assigned this Aug 14, 2024
@pcrespov pcrespov added this to the Eisbock milestone Aug 14, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service a:api framework api, data schemas, e2e Bugs found by or related to the end-2-end testing labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.1%. Comparing base (cafbf96) to head (52715c7).
Report is 454 commits behind head on master.

Files Patch % Lines
...rver/src/simcore_service_webserver/catalog/_api.py 66.6% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6189      +/-   ##
=========================================
- Coverage    84.5%   82.1%    -2.4%     
=========================================
  Files          10     577     +567     
  Lines         214   29440   +29226     
  Branches       25     234     +209     
=========================================
+ Hits          181   24194   +24013     
- Misses         23    5186    +5163     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.9% <61.5%> (?)
unittests 87.6% <84.6%> (+3.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/simcore_service_webserver/catalog/_handlers.py 80.2% <100.0%> (ø)
...rver/src/simcore_service_webserver/catalog/_api.py 58.7% <66.6%> (ø)

... and 585 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is5964/drop-dev-and-e2e branch 3 times, most recently from 7fd34d6 to 8f75b5d Compare August 20, 2024 09:57
@pcrespov pcrespov changed the title WIP: ♻️ Is5964/drop dev and e2e ♻️ web-api: Updated catalog interface and drafted performance test for pagination Aug 20, 2024
@pcrespov pcrespov removed the e2e Bugs found by or related to the end-2-end testing label Aug 20, 2024
@pcrespov pcrespov marked this pull request as ready for review August 20, 2024 09:59
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks!

tests/performance/Dockerfile Outdated Show resolved Hide resolved
tests/performance/Makefile Outdated Show resolved Hide resolved
tests/performance/Makefile Show resolved Hide resolved
@pcrespov pcrespov force-pushed the is5964/drop-dev-and-e2e branch from d37e61b to 52715c7 Compare August 20, 2024 15:06
Copy link

@pcrespov pcrespov enabled auto-merge (squash) August 20, 2024 15:08
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pcrespov pcrespov merged commit 489f744 into ITISFoundation:master Aug 20, 2024
57 checks passed
@pcrespov pcrespov deleted the is5964/drop-dev-and-e2e branch August 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants