-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade and pin portainer/minio/registry versions #6185
⬆️ Upgrade and pin portainer/minio/registry versions #6185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you fix this? These are not used in ops are they? They are dev only compose files
Only reason: Pedro has explicitly suggested it... I probably understood wrongly what was meant with "pinning everywhere". I personally saw some benefit if simcore-devs run the same things that are in the ops stack as well. no problem I can revert. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6185 +/- ##
=========================================
- Coverage 84.5% 78.5% -6.0%
=========================================
Files 10 1103 +1093
Lines 214 45339 +45125
Branches 25 768 +743
=========================================
+ Hits 181 35632 +35451
- Misses 23 9552 +9529
- Partials 10 155 +145
Flags with carried forward coverage won't be shown. Click here to find out more. |
As @sanderegg mentioned, these are not used in the ops stack directly, but they represent what the simcore stack will encounter when deployed alongside the ops stack. Suggestions:
|
Pedro commented and approved, not sure what to do now. Please let me know whether I should pin or unpin, and if you prefer pinning let me know if it is ok to add the SHAs as asked by Pedro. I am actually completely agnostic to this and do not want to debate it :D I am pretty much doing this as it was requested from us to do it. Just let me know how you guys prefer it, thanks. What I would not want to do is introduce tests to assure that everything between the 2 repos, simcore and ops, is tightly coupled w.r.t. versioning. It is a lot of work to make these tests robust and I feel like the resulting advantages do not warrant the developers' time. These tests would be easier to implement in a monorepo, there I would see the point, but not for separated repositories. |
@mrnicegyu11 @pcrespov let's discuss that off line if this is a problem.
|
it is absolutely fine for me to close this PR and leave the dependencies always on the latest upstream version. Please indicate if this is fine for you as well @pcrespov |
What do these changes do?
⬆️ Upgrade and pin portainer/minio/registry versions
Sister-PR to ITISFoundation/osparc-ops-environments#738
Related PRs
ITISFoundation/osparc-ops-environments#738
Dev-ops checklist