Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Sim4Life uses plus button #6167

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 12, 2024

What do these changes do?

Sim4Life tests were starting Sim4Life through the services tab, while users don't have access to it and use the plus button instead.

This PR changes the test so that it uses the plus button.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 12, 2024
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Aug 12, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Aug 12, 2024
@odeimaiz odeimaiz changed the title e2e: Sim4Life and uses plus button e2e: Sim4Life uses plus button Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.8%. Comparing base (cafbf96) to head (24f4ce2).
Report is 420 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cafbf96) and HEAD (24f4ce2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cafbf96) HEAD (24f4ce2)
unittests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6167      +/-   ##
=========================================
- Coverage    84.5%   64.8%   -19.8%     
=========================================
  Files          10     577     +567     
  Lines         214   29408   +29194     
  Branches       25     234     +209     
=========================================
+ Hits          181   19079   +18898     
- Misses         23   10269   +10246     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 587 files with indirect coverage changes

@odeimaiz odeimaiz marked this pull request as ready for review August 12, 2024 10:27
@odeimaiz odeimaiz enabled auto-merge (squash) August 12, 2024 10:27
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link

@odeimaiz odeimaiz requested a review from mguidon August 12, 2024 11:00
@sanderegg sanderegg disabled auto-merge August 12, 2024 11:32
@sanderegg sanderegg merged commit 248fba2 into ITISFoundation:master Aug 12, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants