Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️Maintenance: upgrade static-webserver to latest 2.32.1-alpine #6163

Merged
merged 1 commit into from
Aug 9, 2024
Merged

⬆️Maintenance: upgrade static-webserver to latest 2.32.1-alpine #6163

merged 1 commit into from
Aug 9, 2024

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • the venerable static-webserver which boasted version v1.16.0-alpine seems to have a memory leak and is 3 years old
  • the new 2.32.1-alpine is the latest, built now on Rust and does not seem to show the same problem
    btop reports about 65MB of memory usage and quite stable

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:static-webserver static-webserver service label Aug 9, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Aug 9, 2024
@sanderegg sanderegg self-assigned this Aug 9, 2024
@sanderegg sanderegg force-pushed the maintenance/upgrade-static-webserver branch from a87d803 to 5519c17 Compare August 9, 2024 13:38
YuryHrytsuk
YuryHrytsuk approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mrnicegyu11
mrnicegyu11 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abfahrt! 🚗

pcrespov
pcrespov approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a very smooth migration :-)

odeimaiz
odeimaiz approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@sanderegg sanderegg merged commit 87cec7e into ITISFoundation:master Aug 9, 2024
51 checks passed
@sanderegg sanderegg deleted the maintenance/upgrade-static-webserver branch August 9, 2024 14:18
This was referenced Aug 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@GitHK GitHK Awaiting requested review from GitHK

Assignees

@sanderegg sanderegg

Labels
a:static-webserver static-webserver service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sanderegg @mrnicegyu11 @pcrespov @odeimaiz @YuryHrytsuk