🐛 [Frontend] Annotations fix: Convert named colors to HEX #6162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
changed the title
odeimaiz
requested review from
newton1985,
elisabettai,
pcrespov,
sanderegg and
matusdrobuliak66
elisabettai
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Good catch! But pydantic seems to support hex colors. 🤔
Still some users might get annoyed to see gray annotations, maybe they chose a specific hex code and they try do to it again and then it'll end up gray again -> still a bug for them. Some scientists are very picky on their color choices. 😉
|
This was referenced Aug 15, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When listing projects, pydantic, I believe, is translating the colors used in the annotations from hex to named colors. The frontend wasn't able to understand some of those named colors (i.e. #0FF -> Cyan).
This PR workarounds that problem by checking the named colors in a longer list and converting it again to hex. If the named color doesn't exist in the list it will default it to light gray.
The annotations that were failing in the deserialization step:
Related issue/s
How to test
Dev-ops checklist