Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨AWS library: add start instance method #6159

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 8, 2024

What do these changes do?

  • adds method to start instances after they were stopped.
  • refactor EC2 client to follow same structure as other AWS clients

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added this to the Tom Bombadil milestone Aug 8, 2024
@sanderegg sanderegg self-assigned this Aug 8, 2024
@sanderegg sanderegg force-pushed the autoscaling/add-ec2-methods-for-starting-instances branch from 8de21ab to 657827c Compare August 8, 2024 16:14
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 93.78531% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.2%. Comparing base (cafbf96) to head (0e9727f).
Report is 449 commits behind head on master.

Files Patch % Lines
.../aws-library/src/aws_library/ec2/_error_handler.py 78.5% 6 Missing and 3 partials ⚠️
...e_service_autoscaling/modules/auto_scaling_core.py 75.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6159      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1466    +1456     
  Lines         214   60810   +60596     
  Branches       25    1497    +1472     
=========================================
+ Hits          181   53635   +53454     
- Misses         23    6861    +6838     
- Partials       10     314     +304     
Flag Coverage Δ
integrationtests 64.9% <ø> (?)
unittests 86.1% <93.7%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/aws-library/src/aws_library/ec2/__init__.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ec2/_client.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ec2/_errors.py 100.0% <100.0%> (ø)
...ackages/aws-library/src/aws_library/ec2/_models.py 88.8% <ø> (ø)
packages/aws-library/src/aws_library/ec2/_utils.py 100.0% <100.0%> (ø)
...ing/src/simcore_service_autoscaling/core/errors.py 100.0% <100.0%> (ø)
...g/src/simcore_service_autoscaling/core/settings.py 100.0% <100.0%> (ø)
...oscaling/src/simcore_service_autoscaling/models.py 100.0% <100.0%> (ø)
...vice_autoscaling/modules/auto_scaling_mode_base.py 100.0% <100.0%> (ø)
...scaling/modules/auto_scaling_mode_computational.py 89.6% <100.0%> (ø)
... and 24 more

... and 1387 files with indirect coverage changes

@sanderegg sanderegg force-pushed the autoscaling/add-ec2-methods-for-starting-instances branch from 657827c to 87a5d08 Compare August 9, 2024 15:25
@sanderegg sanderegg marked this pull request as ready for review August 12, 2024 08:42
@sanderegg sanderegg requested a review from pcrespov as a code owner August 12, 2024 08:42
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

packages/aws-library/src/aws_library/ec2/_errors.py Outdated Show resolved Hide resolved
packages/aws-library/src/aws_library/ec2/__init__.py Outdated Show resolved Hide resolved
@sanderegg sanderegg force-pushed the autoscaling/add-ec2-methods-for-starting-instances branch 3 times, most recently from 0a2f657 to 573f267 Compare August 12, 2024 17:11
@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good 👍

@sanderegg sanderegg force-pushed the autoscaling/add-ec2-methods-for-starting-instances branch 4 times, most recently from 2abacff to 7959ad0 Compare August 16, 2024 06:06
@sanderegg sanderegg force-pushed the autoscaling/add-ec2-methods-for-starting-instances branch from 7959ad0 to 0e9727f Compare August 19, 2024 15:25
Copy link

@sanderegg sanderegg merged commit 21c16c9 into ITISFoundation:master Aug 19, 2024
57 checks passed
@sanderegg sanderegg deleted the autoscaling/add-ec2-methods-for-starting-instances branch August 19, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants