Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ folder_utils is now compatible with user #6148

Merged
merged 45 commits into from
Aug 21, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 7, 2024

What do these changes do?

Previously to manage a folder at the DB layer, you would need to provide a single gid.
Now, you can pass in all the gids to which the users has access to.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Aug 7, 2024
@GitHK GitHK added this to the Tom Bombadil milestone Aug 7, 2024
@GitHK GitHK added the a:database associated to postgres service and postgres-database package label Aug 7, 2024
@GitHK GitHK marked this pull request as ready for review August 7, 2024 10:41
@GitHK GitHK requested a review from matusdrobuliak66 as a code owner August 7, 2024 10:41
@GitHK GitHK requested a review from sanderegg August 7, 2024 10:41
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.2%. Comparing base (cafbf96) to head (f6902d3).
Report is 458 commits behind head on master.

Files Patch % Lines
...ase/src/simcore_postgres_database/utils_folders.py 90.1% 5 Missing and 3 partials ⚠️
...ore_service_webserver/folders/_folders_handlers.py 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6148      +/-   ##
=========================================
+ Coverage    84.5%   89.2%    +4.6%     
=========================================
  Files          10    1262    +1252     
  Lines         214   53440   +53226     
  Branches       25     714     +689     
=========================================
+ Hits          181   47671   +47490     
- Misses         23    5609    +5586     
- Partials       10     160     +150     
Flag Coverage Δ
integrationtests 64.9% <33.3%> (?)
unittests 86.8% <89.2%> (+2.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../simcore_service_webserver/folders/_folders_api.py 100.0% <ø> (ø)
...simcore_service_webserver/projects/_folders_api.py 96.5% <ø> (ø)
...ore_service_webserver/folders/_folders_handlers.py 91.5% <66.6%> (ø)
...ase/src/simcore_postgres_database/utils_folders.py 90.7% <90.1%> (ø)

... and 1225 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed blocking before review. And thanks!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for unblock

@GitHK
Copy link
Contributor Author

GitHK commented Aug 8, 2024

I will most likely pick this up when I'm back. It requires some changes. Please wait before reviewing it further, until we have not decided on how the internals are supposed to work.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1200 line... can we maybe go through it together later today? thanks!

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss after today folders meeting with POs, I think we might simplify the design significantly.

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GitHK GitHK requested a review from sanderegg August 20, 2024 14:47
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still find the errors completely not understandable. Also still don't get what the enforce_permission thing does. Also having default in private functions seems a bit dangerous. But I will not block it.

@GitHK GitHK enabled auto-merge (squash) August 21, 2024 07:54
Copy link

@GitHK GitHK merged commit 8c6b2c8 into ITISFoundation:master Aug 21, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-folders-fourth-round branch August 21, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants