-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ folder_utils is now compatible with user #6148
♻️ folder_utils is now compatible with user #6148
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6148 +/- ##
=========================================
+ Coverage 84.5% 89.2% +4.6%
=========================================
Files 10 1262 +1252
Lines 214 53440 +53226
Branches 25 714 +689
=========================================
+ Hits 181 47671 +47490
- Misses 23 5609 +5586
- Partials 10 160 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed blocking before review. And thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for unblock
I will most likely pick this up when I'm back. It requires some changes. Please wait before reviewing it further, until we have not decided on how the internals are supposed to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1200 line... can we maybe go through it together later today? thanks!
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets discuss after today folders meeting with POs, I think we might simplify the design significantly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still find the errors completely not understandable. Also still don't get what the enforce_permission thing does. Also having default in private functions seems a bit dangerous. But I will not block it.
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_folders.py
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
What do these changes do?
Previously to manage a folder at the DB layer, you would need to provide a single
gid
.Now, you can pass in all the
gids
to which the users has access to.Related issue/s
How to test
Dev-ops checklist