✨dynamic-sidecar now logs into DockerHub (⚠️devops)

[GitHK]

⚠️devops

• ⚠️ close all sidecars before deploying

What do these changes do?

When the dynamic-sidecar runs docker compose pull it can fetch some images from Docker Hub. In combination with autoscaling machines and how our networking works, each time a new autoscaling machine is started it lowers the pull cap for the entire deployment by 1.

• ✨ dynamic-sidecar now logs into docker hub when starting (also checks DockerHub for availability)
• ✨ added new env var DIRECTOR_V2_DOCKER_HUB_REGISTRY, if present the dynamic-sidecar will login into DockerHub

Related issue/s

• Use registry pull through cache to avoid Dockerhub rate limits issue when using Private EC2s osparc-ops-environments#716
• closes login dynamic-sidecars to docekerhub osparc-ops-environments#717

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)
• requires this MR to be merged
• requires followup MR to be merged

[codecov]

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.1%. Comparing base (cafbf96) to head (1dba98b).
Report is 447 commits behind head on master.

Files	Patch %	Lines
...c/simcore_service_dynamic_sidecar/core/registry.py	94.7%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6081      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1464    +1454     
  Lines         214   60736   +60522     
  Branches       25    1484    +1459     
=========================================
+ Hits          181   53556   +53375     
- Misses         23    6867    +6844     
- Partials       10     313     +303     

Flag	Coverage Δ
integrationtests	64.9% <72.4%> (?)
unittests	86.1% <97.2%> (+1.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...settings-library/src/settings_library/utils_cli.py	85.5% <100.0%> (ø)
...ngs-library/src/settings_library/utils_encoders.py	100.0% <100.0%> (ø)
...2/src/simcore_service_director_v2/core/settings.py	100.0% <100.0%> (ø)
...es/dynamic_sidecar/docker_service_specs/sidecar.py	87.5% <100.0%> (ø)
...tor-v2/src/simcore_service_director_v2/utils/db.py	100.0% <100.0%> (ø)
...imcore_service_dynamic_sidecar/core/application.py	98.1% <ø> (ø)
...rvice_dynamic_sidecar/core/docker_compose_utils.py	96.6% <100.0%> (ø)
...vice_dynamic_sidecar/core/external_dependencies.py	100.0% <100.0%> (ø)
...c/simcore_service_dynamic_sidecar/core/settings.py	97.2% <100.0%> (ø)
...ervice_dynamic_sidecar/modules/service_liveness.py	100.0% <ø> (ø)
... and 2 more

... and 1407 files with indirect coverage changes

[YuryHrytsuk]

Thank you very much 🙏

Let's first merge ./osparc-config changes

[pcrespov]

thx. Left some suggestions for your consideration

[YuryHrytsuk]

./osparc-config changes are ready to be merged. Thank you 🙏

[sanderegg]

a few comments. we can discuss. thanks a lot!

[sanderegg]

thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud